Prevent adding empty or invalid SSH public keys

James Moger

2014-04-25 039686c54a947f166ba80d79187ba945cac77ad5

 src/main/java/com/gitblit/transport/ssh/keys/BaseKeyCommand.java

@@ -37,17 +37,20 @@
         throws UnsupportedEncodingException, IOException {
      int idx = -1;
      if (sshKeys.isEmpty() || (idx = sshKeys.indexOf("-")) >= 0) {
         String sshKey = "";
         String content = "";
         BufferedReader br = new BufferedReader(new InputStreamReader(
               in, Charsets.UTF_8));
         String line;
         while ((line = br.readLine()) != null) {
            sshKey += line + "\n";
            content += line + "\n";
         }
         if (idx == -1) {
            sshKeys.add(sshKey.trim());
         } else {
            sshKeys.set(idx, sshKey.trim());
         final String sshKey = content.trim();
         if (!sshKey.isEmpty()) {
            if (idx == -1) {
               sshKeys.add(sshKey);
            } else {
               sshKeys.set(idx, sshKey);
            }
         }
      }
      return sshKeys;