Proof of concept #1026

Paul Martin

2016-04-16 eecaad8b8e2c447429c31a01d49260ddd6b4ee03

 src/main/java/com/gitblit/auth/RedmineAuthProvider.java

@@ -19,14 +19,15 @@
import java.io.InputStreamReader;
import java.net.HttpURLConnection;

import org.apache.wicket.util.io.IOUtils;
import org.apache.commons.io.IOUtils;

import com.gitblit.Constants;
import com.gitblit.Constants.AccountType;
import com.gitblit.Constants.Role;
import com.gitblit.Keys;
import com.gitblit.auth.AuthenticationProvider.UsernamePasswordAuthenticationProvider;
import com.gitblit.models.TeamModel;
import com.gitblit.models.UserModel;
import com.gitblit.utils.ArrayUtils;
import com.gitblit.utils.ConnectionUtils;
import com.gitblit.utils.StringUtils;
import com.google.gson.Gson;
@@ -78,6 +79,16 @@
        return false;
    }

    @Override
    public boolean supportsRoleChanges(UserModel user, Role role) {
        return true;
    }

   @Override
   public boolean supportsRoleChanges(TeamModel team, Role role) {
      return true;
   }

    @Override
   public AccountType getAccountType() {
      return AccountType.REDMINE;
@@ -122,24 +133,19 @@
        }

        UserModel user = userManager.getUserModel(username);
        if (user == null)   // create user object for new authenticated user
        if (user == null) {
           // create user object for new authenticated user
           user = new UserModel(username.toLowerCase());
        }

        // create a user cookie
        if (StringUtils.isEmpty(user.cookie) && !ArrayUtils.isEmpty(password)) {
           user.cookie = StringUtils.getSHA1(user.username + new String(password));
        }
        setCookie(user, password);

        // update user attributes from Redmine
        user.accountType = getAccountType();
        user.displayName = current.user.firstname + " " + current.user.lastname;
        user.emailAddress = current.user.mail;
        user.password = Constants.EXTERNAL_ACCOUNT;
        if (!StringUtils.isEmpty(current.user.login)) {
           // only admin users can get login name
           // evidently this is an undocumented behavior of Redmine
           user.canAdmin = true;
        }

        // TODO consider Redmine group mapping for team membership
        // http://www.redmine.org/projects/redmine/wiki/Rest_Users
@@ -159,15 +165,16 @@
        if (!url.endsWith("/")) {
           url = url.concat("/");
        }
        String apiUrl = url + "users/current.json";

        HttpURLConnection http;
        if (username == null) {
           // apikey authentication
           String apiKey = String.valueOf(password);
           String apiUrl = url + "users/current.json?key=" + apiKey;
           http = (HttpURLConnection) ConnectionUtils.openConnection(apiUrl, null, null);
            http.addRequestProperty("X-Redmine-API-Key", apiKey);
        } else {
           // username/password BASIC authentication
           String apiUrl = url + "users/current.json";
           http = (HttpURLConnection) ConnectionUtils.openConnection(apiUrl, username, password);
        }
        http.setRequestMethod("GET");