Proof of concept #1026

Paul Martin

2016-04-16 eecaad8b8e2c447429c31a01d49260ddd6b4ee03

 src/main/java/com/gitblit/git/GitblitUploadPackFactory.java

@@ -15,8 +15,6 @@
 */
package com.gitblit.git;

import javax.servlet.http.HttpServletRequest;

import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.transport.UploadPack;
import org.eclipse.jgit.transport.resolver.ServiceNotAuthorizedException;
@@ -24,9 +22,7 @@
import org.eclipse.jgit.transport.resolver.UploadPackFactory;

import com.gitblit.manager.IAuthenticationManager;
import com.gitblit.models.UserModel;
import com.gitblit.transport.git.GitDaemonClient;
import com.gitblit.transport.ssh.SshSession;

/**
 * The upload pack factory creates an upload pack which controls what refs are
@@ -48,28 +44,13 @@
   public UploadPack create(X req, Repository db)
         throws ServiceNotEnabledException, ServiceNotAuthorizedException {

      UserModel user = UserModel.ANONYMOUS;
      int timeout = 0;

      if (req instanceof HttpServletRequest) {
         // http/https request may or may not be authenticated
         HttpServletRequest client = (HttpServletRequest) req;
         user = authenticationManager.authenticate(client);
         if (user == null) {
            user = UserModel.ANONYMOUS;
         }
      } else if (req instanceof GitDaemonClient) {
      if (req instanceof GitDaemonClient) {
         // git daemon request is always anonymous
         GitDaemonClient client = (GitDaemonClient) req;
         // set timeout from Git daemon
         timeout = client.getDaemon().getTimeout();
      } else if (req instanceof SshSession) {
         // SSH request is always authenticated
         SshSession client = (SshSession) req;
         user = authenticationManager.authenticate(client);
         if (user == null) {
            throw new ServiceNotAuthorizedException();
         }
      }

      UploadPack up = new UploadPack(db);