code cleanup

saheba

2013-03-25 2a8a74bedafdb56b7e7edcb42642dc1eb5e54fff

 src/com/gitblit/client/EditRepositoryDialog.java

@@ -38,7 +38,6 @@


import javax.swing.BoxLayout;

import javax.swing.ButtonGroup;

import javax.swing.DefaultComboBoxModel;

import javax.swing.DefaultListCellRenderer;

import javax.swing.ImageIcon;

import javax.swing.JButton;

@@ -93,6 +92,8 @@


   private JCheckBox useDocs;



   private JCheckBox useIncrementalRevisionNumbers;

	
   private JCheckBox showRemoteBranches;



   private JCheckBox showReadme;

@@ -117,14 +118,16 @@


   private JComboBox federationStrategy;



   private JComboBox ownerField;

   private JPalette<String> ownersPalette;



   private JComboBox headRefField;

   

   private JComboBox gcPeriod;

   

   private JTextField gcThreshold;



	
   private JComboBox maxActivityCommits;

	
   private RegistrantPermissionsPanel usersPalette;



   private JPalette<String> setsPalette;

@@ -205,12 +208,14 @@
      gcThreshold = new JTextField(8);

      gcThreshold.setText(anRepository.gcThreshold);



      ownerField = new JComboBox();

      ownersPalette = new JPalette<String>(true);



      useTickets = new JCheckBox(Translation.get("gb.useTicketsDescription"),

            anRepository.useTickets);

      useDocs = new JCheckBox(Translation.get("gb.useDocsDescription"),

            anRepository.useDocs);

      useIncrementalRevisionNumbers = new JCheckBox(Translation.get("gb.useIncrementalRevisionNumbersDescription"),

            anRepository.useIncrementalRevisionNumbers);

      showRemoteBranches = new JCheckBox(

            Translation.get("gb.showRemoteBranchesDescription"),

            anRepository.showRemoteBranches);

@@ -224,6 +229,9 @@
            anRepository.skipSummaryMetrics);

      isFrozen = new JCheckBox(Translation.get("gb.isFrozenDescription"),

            anRepository.isFrozen);



      maxActivityCommits = new JComboBox(new Integer [] { -1, 0, 25, 50, 75, 100, 150, 250, 500 });

      maxActivityCommits.setSelectedItem(anRepository.maxActivityCommits);



      mailingListsField = new JTextField(

            ArrayUtils.isEmpty(anRepository.mailingLists) ? ""

@@ -250,7 +258,7 @@
      allowAuthenticated.addItemListener(new ItemListener() {

         @Override

         public void itemStateChanged(ItemEvent e) {

            if (e.getStateChange() == ItemEvent.SELECTED) {

            if (e.getStateChange() == ItemEvent.SELECTED) {					
               usersPalette.setEnabled(false);

               teamsPalette.setEnabled(false);

            }

@@ -305,6 +313,8 @@
            useTickets));

      fieldsPanel

            .add(newFieldPanel(Translation.get("gb.enableDocs"), useDocs));

      fieldsPanel

      .add(newFieldPanel(Translation.get("gb.enableIncrementalRevisionNumbers"), useIncrementalRevisionNumbers));

      fieldsPanel.add(newFieldPanel(Translation.get("gb.showRemoteBranches"),

            showRemoteBranches));

      fieldsPanel.add(newFieldPanel(Translation.get("gb.showReadme"),

@@ -314,6 +324,8 @@
                  skipSizeCalculation));

      fieldsPanel.add(newFieldPanel(Translation.get("gb.skipSummaryMetrics"),

            skipSummaryMetrics));

      fieldsPanel.add(newFieldPanel(Translation.get("gb.maxActivityCommits"),

            maxActivityCommits));

      fieldsPanel.add(newFieldPanel(Translation.get("gb.mailingLists"),

            mailingListsField));



@@ -327,10 +339,10 @@


      usersPalette = new RegistrantPermissionsPanel(RegistrantType.USER);



      JPanel northFieldsPanel = new JPanel(new GridLayout(0, 1, 0, 5));

      northFieldsPanel.add(newFieldPanel(Translation.get("gb.owner"), ownerField));

      JPanel northFieldsPanel = new JPanel(new BorderLayout(0, 5));

      northFieldsPanel.add(newFieldPanel(Translation.get("gb.owners"), ownersPalette), BorderLayout.NORTH);

      northFieldsPanel.add(newFieldPanel(Translation.get("gb.accessRestriction"),

            accessRestriction), BorderLayout.NORTH);

            accessRestriction), BorderLayout.CENTER);



      JPanel northAccessPanel = new JPanel(new BorderLayout(5, 5));

      northAccessPanel.add(northFieldsPanel, BorderLayout.NORTH);

@@ -462,9 +474,11 @@
         

         allowAuthenticated.setEnabled(false);

         allowNamed.setEnabled(false);

         verifyCommitter.setEnabled(false);

      } else {

         allowAuthenticated.setEnabled(true);

         allowNamed.setEnabled(true);

         verifyCommitter.setEnabled(true);

         

         if (allowNamed.isSelected()) {

            usersPalette.setEnabled(true);

@@ -547,18 +561,20 @@


      repository.name = rname;

      repository.description = descriptionField.getText();

      repository.owner = ownerField.getSelectedItem() == null ? null

            : ownerField.getSelectedItem().toString();

      repository.owners.clear();

      repository.owners.addAll(ownersPalette.getSelections());

      repository.HEAD = headRefField.getSelectedItem() == null ? null

            : headRefField.getSelectedItem().toString();

      repository.gcPeriod = (Integer) gcPeriod.getSelectedItem();

      repository.gcThreshold = gcThreshold.getText();

      repository.useTickets = useTickets.isSelected();

      repository.useDocs = useDocs.isSelected();

      repository.useIncrementalRevisionNumbers = useIncrementalRevisionNumbers.isSelected();

      repository.showRemoteBranches = showRemoteBranches.isSelected();

      repository.showReadme = showReadme.isSelected();

      repository.skipSizeCalculation = skipSizeCalculation.isSelected();

      repository.skipSummaryMetrics = skipSummaryMetrics.isSelected();

      repository.maxActivityCommits = (Integer) maxActivityCommits.getSelectedItem();

      

      repository.isFrozen = isFrozen.isSelected();

      repository.allowForks = allowForks.isSelected();

@@ -619,11 +635,8 @@
      this.allowNamed.setSelected(!authenticated);

   }



   public void setUsers(String owner, List<String> all, List<RegistrantAccessPermission> permissions) {

      ownerField.setModel(new DefaultComboBoxModel(all.toArray()));

      if (!StringUtils.isEmpty(owner)) {

         ownerField.setSelectedItem(owner);

      }

   public void setUsers(List<String> owners, List<String> all, List<RegistrantAccessPermission> permissions) {

      ownersPalette.setObjects(all, owners);

      usersPalette.setObjects(all, permissions);

   }