Support local accounts with LdapUserService and RedmineUserService (issue-183)

James Moger

2013-01-04 4e3c152fa7e97200855ba0d2716362dbe7976920

 src/com/gitblit/wicket/pages/EditTeamPage.java

@@ -27,7 +27,7 @@
import org.apache.wicket.behavior.SimpleAttributeModifier;

import org.apache.wicket.extensions.markup.html.form.palette.Palette;

import org.apache.wicket.markup.html.form.Button;

import org.apache.wicket.markup.html.form.ChoiceRenderer;

import org.apache.wicket.markup.html.form.CheckBox;

import org.apache.wicket.markup.html.form.Form;

import org.apache.wicket.markup.html.form.TextField;

import org.apache.wicket.model.CompoundPropertyModel;

@@ -36,15 +36,18 @@
import org.apache.wicket.model.util.CollectionModel;

import org.apache.wicket.model.util.ListModel;



import com.gitblit.Constants.AccessRestrictionType;

import com.gitblit.GitBlit;

import com.gitblit.GitBlitException;

import com.gitblit.models.RepositoryModel;

import com.gitblit.Keys;

import com.gitblit.Constants.RegistrantType;

import com.gitblit.models.RegistrantAccessPermission;

import com.gitblit.models.TeamModel;

import com.gitblit.utils.StringUtils;

import com.gitblit.wicket.RequiresAdminRole;

import com.gitblit.wicket.StringChoiceRenderer;

import com.gitblit.wicket.WicketUtils;

import com.gitblit.wicket.panels.BulletListPanel;

import com.gitblit.wicket.panels.RegistrantPermissionsPanel;



@RequiresAdminRole

public class EditTeamPage extends RootSubPage {

@@ -58,6 +61,8 @@
      super();

      isCreate = true;

      setupPage(new TeamModel(""));

      setStatelessHint(false);

      setOutputMarkupId(true);

   }



   public EditTeamPage(PageParameters params) {

@@ -67,6 +72,13 @@
      String name = WicketUtils.getTeamname(params);

      TeamModel model = GitBlit.self().getTeamModel(name);

      setupPage(model);

      setStatelessHint(false);

      setOutputMarkupId(true);

   }



   @Override

   protected boolean requiresPageMap() {

      return true;

   }



   protected void setupPage(final TeamModel teamModel) {

@@ -78,14 +90,7 @@


      CompoundPropertyModel<TeamModel> model = new CompoundPropertyModel<TeamModel>(teamModel);



      List<String> repos = new ArrayList<String>();

      for (String repo : GitBlit.self().getRepositoryList()) {

         RepositoryModel repositoryModel = GitBlit.self().getRepositoryModel(repo);

         if (repositoryModel.accessRestriction.exceeds(AccessRestrictionType.NONE)) {

            repos.add(repo);

         }

      }

      StringUtils.sortRepositorynames(repos);

      List<String> repos = getAccessRestrictedRepositoryList(true, null);



      List<String> teamUsers = new ArrayList<String>(teamModel.users);

      Collections.sort(teamUsers);

@@ -93,16 +98,12 @@
      List<String> postReceiveScripts = new ArrayList<String>();



      final String oldName = teamModel.name;



      // repositories palette

      final Palette<String> repositories = new Palette<String>("repositories",

            new ListModel<String>(new ArrayList<String>(teamModel.repositories)),

            new CollectionModel<String>(repos), new ChoiceRenderer<String>("", ""), 10, false);

      final List<RegistrantAccessPermission> permissions = teamModel.getRepositoryPermissions();



      // users palette

      final Palette<String> users = new Palette<String>("users", new ListModel<String>(

            new ArrayList<String>(teamUsers)), new CollectionModel<String>(GitBlit.self()

            .getAllUsernames()), new ChoiceRenderer<String>("", ""), 10, false);

            .getAllUsernames()), new StringChoiceRenderer(), 10, false);



      // pre-receive palette

      if (teamModel.preReceiveScripts != null) {

@@ -110,8 +111,8 @@
      }

      final Palette<String> preReceivePalette = new Palette<String>("preReceiveScripts",

            new ListModel<String>(preReceiveScripts), new CollectionModel<String>(GitBlit

                  .self().getPreReceiveScriptsUnused(null)), new ChoiceRenderer<String>("",

                  ""), 12, true);

                  .self().getPreReceiveScriptsUnused(null)), new StringChoiceRenderer(),

                  12, true);



      // post-receive palette

      if (teamModel.postReceiveScripts != null) {

@@ -119,8 +120,8 @@
      }

      final Palette<String> postReceivePalette = new Palette<String>("postReceiveScripts",

            new ListModel<String>(postReceiveScripts), new CollectionModel<String>(GitBlit

                  .self().getPostReceiveScriptsUnused(null)), new ChoiceRenderer<String>("",

                  ""), 12, true);

                  .self().getPostReceiveScriptsUnused(null)), new StringChoiceRenderer(),

                        12, true);



      Form<TeamModel> form = new Form<TeamModel>("editForm", model) {



@@ -135,27 +136,20 @@
         protected void onSubmit() {

            String teamname = teamModel.name;

            if (StringUtils.isEmpty(teamname)) {

               error("Please enter a teamname!");

               error(getString("gb.pleaseSetTeamName"));

               return;

            }

            if (isCreate) {

               TeamModel model = GitBlit.self().getTeamModel(teamname);

               if (model != null) {

                  error(MessageFormat.format("Team name ''{0}'' is unavailable.", teamname));

                  error(MessageFormat.format(getString("gb.teamNameUnavailable"), teamname));

                  return;

               }

            }

            Iterator<String> selectedRepositories = repositories.getSelectedChoices();

            List<String> repos = new ArrayList<String>();

            while (selectedRepositories.hasNext()) {

               repos.add(selectedRepositories.next().toLowerCase());

            // update team permissions

            for (RegistrantAccessPermission repositoryPermission : permissions) {

               teamModel.setRepositoryPermission(repositoryPermission.registrant, repositoryPermission.permission);

            }

            if (repos.size() == 0) {

               error("A team must specify at least one repository.");

               return;

            }

            teamModel.repositories.clear();

            teamModel.repositories.addAll(repos);



            Iterator<String> selectedUsers = users.getSelectedChoices();

            List<String> members = new ArrayList<String>();

@@ -206,7 +200,7 @@
            setRedirect(false);

            if (isCreate) {

               // create another team

               info(MessageFormat.format("New team ''{0}'' successfully created.",

               info(MessageFormat.format(getString("gb.teamCreated"),

                     teamModel.name));

            }

            // back to users page

@@ -217,14 +211,21 @@
      // do not let the browser pre-populate these fields

      form.add(new SimpleAttributeModifier("autocomplete", "off"));



      // not all user services support manipulating team memberships

      boolean editMemberships = GitBlit.self().supportsTeamMembershipChanges(null);

		
      // field names reflective match TeamModel fields

      form.add(new TextField<String>("name"));

      form.add(users);

      form.add(new CheckBox("canAdmin"));

      form.add(new CheckBox("canFork").setEnabled(GitBlit.getBoolean(Keys.web.allowForking, true)));

      form.add(new CheckBox("canCreate"));

      form.add(users.setEnabled(editMemberships));

      mailingLists = new Model<String>(teamModel.mailingLists == null ? ""

            : StringUtils.flattenStrings(teamModel.mailingLists, " "));

      form.add(new TextField<String>("mailingLists", mailingLists));



      form.add(repositories);

      form.add(new RegistrantPermissionsPanel("repositories", RegistrantType.REPOSITORY,

            repos, permissions, getAccessPermissions()));

      form.add(preReceivePalette);

      form.add(new BulletListPanel("inheritedPreReceive", "inherited", GitBlit.self()

            .getPreReceiveScriptsInherited(null)));