Merge pull request #1073 from gitblit/1062-DocEditorUpdates

Paul Martin

2016-04-30 a502d96a860456ec5e8c96761db70f7cabb74751

 src/main/java/com/gitblit/wicket/pages/EditTicketPage.java

@@ -23,6 +23,8 @@
import java.util.TreeSet;



import org.apache.wicket.PageParameters;

import org.apache.wicket.ajax.AjaxRequestTarget;

import org.apache.wicket.ajax.markup.html.form.AjaxButton;

import org.apache.wicket.markup.html.basic.Label;

import org.apache.wicket.markup.html.form.Button;

import org.apache.wicket.markup.html.form.DropDownChoice;

@@ -35,6 +37,7 @@


import com.gitblit.Constants;

import com.gitblit.Constants.AccessPermission;

import com.gitblit.Constants.AuthorizationControl;

import com.gitblit.models.RegistrantAccessPermission;

import com.gitblit.models.TicketModel;

import com.gitblit.models.TicketModel.Change;

@@ -49,6 +52,7 @@
import com.gitblit.wicket.GitBlitWebSession;

import com.gitblit.wicket.WicketUtils;

import com.gitblit.wicket.panels.MarkdownTextArea;

import com.google.common.base.Optional;



/**

 * Page for editing a ticket.

@@ -80,6 +84,10 @@


   private Label descriptionPreview;



   private IModel<TicketModel.Priority> priorityModel;



   private IModel<TicketModel.Severity> severityModel;



   public EditTicketPage(PageParameters params) {

      super(params);



@@ -101,6 +109,9 @@
            || !currentUser.canEdit(ticket, getRepositoryModel())

            || !app().tickets().isAcceptingTicketUpdates(getRepositoryModel())) {

         setResponsePage(TicketsPage.class, WicketUtils.newObjectParameter(repositoryName, "" + ticketId));



         // create a placeholder object so we don't trigger NPEs

         ticket = new TicketModel();

      }



      typeModel = Model.of(ticket.type);

@@ -108,109 +119,15 @@
      topicModel = Model.of(ticket.topic == null ? "" : ticket.topic);

      responsibleModel = Model.of();

      milestoneModel = Model.of();

      mergeToModel = Model.of(ticket.mergeTo == null ? "" : ticket.mergeTo);

      mergeToModel = Model.of(ticket.mergeTo == null ? getRepositoryModel().mergeTo : ticket.mergeTo);

      statusModel = Model.of(ticket.status);

      priorityModel = Model.of(ticket.priority);

      severityModel = Model.of(ticket.severity);



      setStatelessHint(false);

      setOutputMarkupId(true);



      Form<Void> form = new Form<Void>("editForm") {



         private static final long serialVersionUID = 1L;



         @Override

         protected void onSubmit() {

            long ticketId = 0L;

            try {

               String h = WicketUtils.getObject(getPageParameters());

               ticketId = Long.parseLong(h);

            } catch (Exception e) {

               setResponsePage(TicketsPage.class, WicketUtils.newRepositoryParameter(repositoryName));

            }



            TicketModel ticket = app().tickets().getTicket(getRepositoryModel(), ticketId);



            String createdBy = GitBlitWebSession.get().getUsername();

            Change change = new Change(createdBy);



            String title = titleModel.getObject();

            if (!StringUtils.isEmpty(title) && !ticket.title.equals(title)) {

               // title change

               change.setField(Field.title, title);

            }



            String description = descriptionEditor.getText();

            if ((StringUtils.isEmpty(ticket.body) && !StringUtils.isEmpty(description))

                  || (!StringUtils.isEmpty(ticket.body) && !ticket.body.equals(description))) {

               // description change

               change.setField(Field.body, description);

            }



            Status status = statusModel.getObject();

            if (!ticket.status.equals(status)) {

               // status change

               change.setField(Field.status, status);

            }



            Type type = typeModel.getObject();

            if (!ticket.type.equals(type)) {

               // type change

               change.setField(Field.type, type);

            }



            String topic = topicModel.getObject();

            if ((StringUtils.isEmpty(ticket.topic) && !StringUtils.isEmpty(topic))

                  || (!StringUtils.isEmpty(topic) && !topic.equals(ticket.topic))) {

               // topic change

               change.setField(Field.topic, topic);

            }



            TicketResponsible responsible = responsibleModel == null ? null : responsibleModel.getObject();

            if (responsible != null && !responsible.username.equals(ticket.responsible)) {

               // responsible change

               change.setField(Field.responsible, responsible.username);

               if (!StringUtils.isEmpty(responsible.username)) {

                  if (!ticket.isWatching(responsible.username)) {

                     change.watch(responsible.username);

                  }

               }

            }



            TicketMilestone milestone = milestoneModel == null ? null : milestoneModel.getObject();

            if (milestone != null && !milestone.name.equals(ticket.milestone)) {

               // milestone change

               if (NIL.equals(milestone.name)) {

                  change.setField(Field.milestone, "");

               } else {

                  change.setField(Field.milestone, milestone.name);

               }

            }



            String mergeTo = mergeToModel.getObject();

            if ((StringUtils.isEmpty(ticket.mergeTo) && !StringUtils.isEmpty(mergeTo))

                  || (!StringUtils.isEmpty(mergeTo) && !mergeTo.equals(ticket.mergeTo))) {

               // integration branch change

               change.setField(Field.mergeTo, mergeTo);

            }



            if (change.hasFieldChanges()) {

               if (!ticket.isWatching(createdBy)) {

                  change.watch(createdBy);

               }

               ticket = app().tickets().updateTicket(getRepositoryModel(), ticket.number, change);

               if (ticket != null) {

                  TicketNotifier notifier = app().tickets().createNotifier();

                  notifier.sendMailing(ticket);

                  setResponsePage(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number));

               } else {

                  // TODO error

               }

            } else {

               // nothing to change?!

               setResponsePage(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number));

            }

         }

      };

      Form<Void> form = new Form<Void>("editForm");

      add(form);



      List<Type> typeChoices;

@@ -224,7 +141,7 @@
      form.add(new TextField<String>("title", titleModel));

      form.add(new TextField<String>("topic", topicModel));



      final IModel<String> markdownPreviewModel = new Model<String>();

      final IModel<String> markdownPreviewModel = Model.of(ticket.body == null ? "" : ticket.body);

      descriptionPreview = new Label("descriptionPreview", markdownPreviewModel);

      descriptionPreview.setEscapeModelStrings(false);

      descriptionPreview.setOutputMarkupId(true);

@@ -250,20 +167,30 @@
      status.add(new DropDownChoice<TicketModel.Status>("status", statusModel, statusChoices));

      form.add(status);



      List<TicketModel.Severity> severityChoices = Arrays.asList(TicketModel.Severity.choices());

      form.add(new DropDownChoice<TicketModel.Severity>("severity", severityModel, severityChoices));



      if (currentUser.canAdmin(ticket, getRepositoryModel())) {

         // responsible

         Set<String> userlist = new TreeSet<String>(ticket.getParticipants());



         for (RegistrantAccessPermission rp : app().repositories().getUserAccessPermissions(getRepositoryModel())) {

            if (rp.permission.atLeast(AccessPermission.PUSH) && !rp.isTeam()) {

               userlist.add(rp.registrant);

         if (UserModel.ANONYMOUS.canPush(getRepositoryModel())

               || AuthorizationControl.AUTHENTICATED == getRepositoryModel().authorizationControl) {

            //    authorization is ANONYMOUS or AUTHENTICATED (i.e. all users can be set responsible)

            userlist.addAll(app().users().getAllUsernames());

         } else {

            // authorization is by NAMED users (users with PUSH permission can be set responsible)

            for (RegistrantAccessPermission rp : app().repositories().getUserAccessPermissions(getRepositoryModel())) {

               if (rp.permission.atLeast(AccessPermission.PUSH)) {

                  userlist.add(rp.registrant);

               }

            }

         }



         List<TicketResponsible> responsibles = new ArrayList<TicketResponsible>();

         for (String username : userlist) {

            UserModel user = app().users().getUserModel(username);

            if (user != null) {

            if (user != null && !user.disabled) {

               TicketResponsible responsible = new TicketResponsible(user);

               responsibles.add(responsible);

               if (user.username.equals(ticket.responsible)) {

@@ -296,10 +223,16 @@
            milestones.add(new TicketMilestone(NIL));

         }



         // milestone

         Fragment milestone = new Fragment("milestone", "milestoneFragment", this);



         milestone.add(new DropDownChoice<TicketMilestone>("milestone", milestoneModel, milestones));

         form.add(milestone.setVisible(!milestones.isEmpty()));



         // priority

         Fragment priority = new Fragment("priority", "priorityFragment", this);

         List<TicketModel.Priority> priorityChoices = Arrays.asList(TicketModel.Priority.choices());

         priority.add(new DropDownChoice<TicketModel.Priority>("priority", priorityModel, priorityChoices));

         form.add(priority);



         // mergeTo (integration branch)

         List<String> branches = new ArrayList<String>();

@@ -309,8 +242,8 @@
               branches.add(Repository.shortenRefName(branch));

            }

         }

         branches.remove(Repository.shortenRefName(getRepositoryModel().HEAD));

         branches.add(0, Repository.shortenRefName(getRepositoryModel().HEAD));

         branches.remove(Repository.shortenRefName(getRepositoryModel().mergeTo));

         branches.add(0, Repository.shortenRefName(getRepositoryModel().mergeTo));



         Fragment mergeto = new Fragment("mergeto", "mergeToFragment", this);

         mergeto.add(new DropDownChoice<String>("mergeto", mergeToModel, branches));

@@ -320,8 +253,123 @@
         form.add(new Label("responsible").setVisible(false));

         form.add(new Label("milestone").setVisible(false));

         form.add(new Label("mergeto").setVisible(false));

         form.add(new Label("priority").setVisible(false));

      }

      form.add(new Button("update"));



      form.add(new AjaxButton("update") {



         private static final long serialVersionUID = 1L;



         @Override

         protected void onSubmit(AjaxRequestTarget target, Form<?> form) {

            long ticketId = 0L;

            try {

               String h = WicketUtils.getObject(getPageParameters());

               ticketId = Long.parseLong(h);

            } catch (Exception e) {

               setResponsePage(TicketsPage.class, WicketUtils.newRepositoryParameter(repositoryName));

            }



            TicketModel ticket = app().tickets().getTicket(getRepositoryModel(), ticketId);



            String createdBy = GitBlitWebSession.get().getUsername();

            Change change = new Change(createdBy);



            String title = titleModel.getObject();

            if (StringUtils.isEmpty(title)) {

               return;

            }



            if (!ticket.title.equals(title)) {

               // title change

               change.setField(Field.title, title);

            }



            String description = Optional.fromNullable(descriptionEditor.getText()).or("");

            if ((StringUtils.isEmpty(ticket.body) && !StringUtils.isEmpty(description))

                  || (!StringUtils.isEmpty(ticket.body) && !ticket.body.equals(description))) {

               // description change

               change.setField(Field.body, description);

            }



            Status status = statusModel.getObject();

            if (!ticket.status.equals(status)) {

               // status change

               change.setField(Field.status, status);

            }



            Type type = typeModel.getObject();

            if (!ticket.type.equals(type)) {

               // type change

               change.setField(Field.type, type);

            }



            String topic = Optional.fromNullable(topicModel.getObject()).or("");

            if ((StringUtils.isEmpty(ticket.topic) && !StringUtils.isEmpty(topic))

               || (!StringUtils.isEmpty(ticket.topic) && !ticket.topic.equals(topic))) {

               // topic change

               change.setField(Field.topic, topic);

            }



            TicketResponsible responsible = responsibleModel == null ? null : responsibleModel.getObject();

            if (responsible != null && !responsible.username.equals(ticket.responsible)) {

               // responsible change

               change.setField(Field.responsible, responsible.username);

               if (!StringUtils.isEmpty(responsible.username)) {

                  if (!ticket.isWatching(responsible.username)) {

                     change.watch(responsible.username);

                  }

               }

            }



            TicketMilestone milestone = milestoneModel == null ? null : milestoneModel.getObject();

            if (milestone != null && !milestone.name.equals(ticket.milestone)) {

               // milestone change

               if (NIL.equals(milestone.name)) {

                  change.setField(Field.milestone, "");

               } else {

                  change.setField(Field.milestone, milestone.name);

               }

            }



            TicketModel.Priority priority = priorityModel.getObject();

            if (!ticket.priority.equals(priority))

            {

               change.setField(Field.priority, priority);

            }



            TicketModel.Severity severity = severityModel.getObject();

            if (!ticket.severity.equals(severity))

            {

               change.setField(Field.severity, severity);

            }



            String mergeTo = mergeToModel.getObject();

            if ((StringUtils.isEmpty(ticket.mergeTo) && !StringUtils.isEmpty(mergeTo))

                  || (!StringUtils.isEmpty(mergeTo) && !mergeTo.equals(ticket.mergeTo))) {

               // integration branch change

               change.setField(Field.mergeTo, mergeTo);

            }



            if (change.hasFieldChanges()) {

               if (!ticket.isWatching(createdBy)) {

                  change.watch(createdBy);

               }

               ticket = app().tickets().updateTicket(getRepositoryModel(), ticket.number, change);

               if (ticket != null) {

                  TicketNotifier notifier = app().tickets().createNotifier();

                  notifier.sendMailing(ticket);

                  redirectTo(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number));

               } else {

                  // TODO error

               }

            } else {

               // nothing to change?!

               redirectTo(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number));

            }

         }

      });



      Button cancel = new Button("cancel") {

         private static final long serialVersionUID = 1L;