fix sql-update

Dominik

2015-01-11 3783361d56e20ad3d4cf16c743b7228a97fc297a

 server/lib/classes/cron.d/500-backup.inc.php

@@ -51,6 +51,7 @@
      global $app, $conf;

      $server_config = $app->getconf->get_server_config($conf['server_id'], 'server');
      $global_config = $app->getconf->get_global_config('sites');
      $backup_dir = $server_config['backup_dir'];
      $backup_mode = $server_config['backup_mode'];
      if($backup_mode == '') $backup_mode = 'userzip';
@@ -71,22 +72,13 @@
         } else {
            chmod(escapeshellcmd($backup_dir), $backup_dir_permissions);
         }
			
         //* mount backup directory, if necessary
         $run_backups = true;
         $server_config['backup_dir_mount_cmd'] = trim($server_config['backup_dir_mount_cmd']);
         if($server_config['backup_dir_is_mount'] == 'y' && $server_config['backup_dir_mount_cmd'] != ''){
            if(!$app->system->is_mounted($backup_dir)){
               exec(escapeshellcmd($server_config['backup_dir_mount_cmd']));
               sleep(1);
               if(!$app->system->is_mounted($backup_dir)) $run_backups = false;
            }
         }

            $run_backups = true;
            //* mount backup directory, if necessary
            if( $server_config['backup_dir_is_mount'] == 'y' && !$app->system->mount_backup_dir($backup_dir) ) $run_backups = false;
         if($run_backups){
            //* backup only active domains
            $sql = "SELECT * FROM web_domain WHERE server_id = '".$conf['server_id']."' AND (type = 'vhost' OR type = 'vhostsubdomain') AND active = 'y'";
            $records = $app->db->queryAllRecords($sql);
            $sql = "SELECT * FROM web_domain WHERE server_id = ? AND (type = 'vhost' OR type = 'vhostsubdomain' OR type = 'vhostalias') AND active = 'y'";
            $records = $app->db->queryAllRecords($sql, $conf['server_id']);
            if(is_array($records)) {
               foreach($records as $rec) {

@@ -131,16 +123,21 @@
                     }
                     if($retval == 0 || ($backup_mode != 'userzip' && $retval == 1) || ($backup_mode == 'userzip' && $retval == 12)) { // tar can return 1, zip can return 12(due to harmless warings) and still create valid backups  
                        if(is_file($web_backup_dir.'/'.$web_backup_file)){
                           chown($web_backup_dir.'/'.$web_backup_file, 'root');
                           chgrp($web_backup_dir.'/'.$web_backup_file, 'root');
                           $backupusername = ($global_config['backups_include_into_web_quota'] == 'y') ? $web_user : 'root';
                           $backupgroup = ($global_config['backups_include_into_web_quota'] == 'y') ? $web_group : 'root';
                           chown($web_backup_dir.'/'.$web_backup_file, $backupusername);
                           chgrp($web_backup_dir.'/'.$web_backup_file, $backupgroup);
                           chmod($web_backup_dir.'/'.$web_backup_file, 0750);

                           //* Insert web backup record in database
                           //$insert_data = "(server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",".$web_id.",'web','".$backup_mode."',".time().",'".$app->db->quote($web_backup_file)."')";
                           //$app->dbmaster->datalogInsert('web_backup', $insert_data, 'backup_id');
                           $sql = "INSERT INTO web_backup (server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",".$web_id.",'web','".$backup_mode."',".time().",'".$app->db->quote($web_backup_file)."')";
                           $app->db->query($sql);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                           $filesize = filesize($web_backup_dir.'/'.$web_backup_file);
                           $sql = "INSERT INTO web_backup (server_id, parent_domain_id, backup_type, backup_mode, tstamp, filename, filesize) VALUES (?, ?, ?, ?, ?, ?, ?)";
                           $app->db->query($sql, $conf['server_id'], $web_id, 'web', $backup_mode, time(), $web_backup_file, $filesize);
                           if($app->db->dbHost != $app->dbmaster->dbHost) 
                              $app->dbmaster->query($sql, $conf['server_id'], $web_id, 'web', $backup_mode, time(), $web_backup_file, $filesize);
                           unset($filesize);
                        }
                     } else {
                        if(is_file($web_backup_dir.'/'.$web_backup_file)) unlink($web_backup_dir.'/'.$web_backup_file);
@@ -167,9 +164,9 @@
                           //$tmp = $app->dbmaster->queryOneRecord($sql);
                           //$app->dbmaster->datalogDelete('web_backup', 'backup_id', $tmp['backup_id']);
                           //$sql = "DELETE FROM web_backup WHERE backup_id = ".intval($tmp['backup_id']);
                           $sql = "DELETE FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($files[$n])."'";
                           $app->db->query($sql);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                           $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                           $app->db->query($sql, $conf['server_id'], $web_id, $files[$n]);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'],  $web_id, $files[$n]);
                        }
                     }

@@ -199,16 +196,15 @@
                     $web_backup_dir = realpath($backup_dir.'/web'.$web_id);
                     if(is_dir($web_backup_dir)) {
                        exec('sudo -u '.escapeshellarg($web_user).' rm -f '.escapeshellarg($web_backup_dir.'/*'));
                        $sql = "DELETE FROM web_backup WHERE server_id = ".intval($conf['server_id'])." AND parent_domain_id = ".intval($web_id);
                        $app->db->query($sql);
                        if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                        $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ?";
                        $app->db->query($sql, $conf['server_id'], $web_id);
                        if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $web_id);
                     }
                  }
               }
            }

            $sql = "SELECT * FROM web_database WHERE server_id = ".$conf['server_id']." AND backup_interval != 'none' AND backup_interval != ''";
            $records = $app->db->queryAllRecords($sql);
            $records = $app->db->queryAllRecords("SELECT * FROM web_database WHERE server_id = ? AND backup_interval != 'none' AND backup_interval != ''", $conf['server_id']);
            if(is_array($records)) {

               include 'lib/mysql_clientdb.conf';
@@ -222,8 +218,16 @@
                     $db_backup_dir = $backup_dir.'/web'.$web_id;
                     if(!is_dir($db_backup_dir)) mkdir($db_backup_dir, 0750);
                     chmod($db_backup_dir, 0750);
                     chown($db_backup_dir, 'root');
                     chgrp($db_backup_dir, 'root');
                     $backupusername = 'root';
                     $backupgroup = 'root';
                     if ($global_config['backups_include_into_web_quota'] == 'y') {
                        $sql = "SELECT * FROM web_domain WHERE domain_id = ".$rec['parent_domain_id'];
                        $webdomain = $app->db->queryOneRecord($sql);
                        $backupusername = $webdomain['system_user'];
                        $backupgroup = $webdomain['system_group'];
                     }
                     chown($db_backup_dir, $backupusername);
                     chgrp($db_backup_dir, $backupgroup);

                     //* Do the mysql database backup with mysqldump
                     $db_id = $rec['database_id'];
@@ -245,9 +249,12 @@
                           //* Insert web backup record in database
                           //$insert_data = "(server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",$web_id,'mysql','sqlgz',".time().",'".$app->db->quote($db_backup_file).".gz')";
                           //$app->dbmaster->datalogInsert('web_backup', $insert_data, 'backup_id');
                           $sql = "INSERT INTO web_backup (server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",$web_id,'mysql','sqlgz',".time().",'".$app->db->quote($db_backup_file).".gz')";
                           $app->db->query($sql);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                           $filesize = filesize($db_backup_dir.'/'.$db_backup_file.'.gz');
                           $sql = "INSERT INTO web_backup (server_id, parent_domain_id, backup_type, backup_mode, tstamp, filename, filesize) VALUES (?, ?, ?, ?, ?, ?, ?)";
                           $app->db->query($sql, $conf['server_id'], $web_id, 'mysql', 'sqlgz', time(), $db_backup_file.'.gz', $filesize);
                           if($app->db->dbHost != $app->dbmaster->dbHost) 
                              $app->dbmaster->query($sql, $conf['server_id'], $web_id, 'mysql', 'sqlgz', time(), $db_backup_file.'.gz', $filesize);
                           unset($filesize);
                        }
                     } else {
                        if(is_file($db_backup_dir.'/'.$db_backup_file.'.gz')) unlink($db_backup_dir.'/'.$db_backup_file.'.gz');
@@ -277,9 +284,9 @@
                              //$sql = "SELECT backup_id FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($filelist[$n])."'";
                              //$tmp = $app->dbmaster->queryOneRecord($sql);
                              //$sql = "DELETE FROM web_backup WHERE backup_id = ".intval($tmp['backup_id']);
                              $sql = "DELETE FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($filelist[$n])."'";
                              $app->db->query($sql);
                              if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                              $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                              $app->db->query($sql, $conf['server_id'], $web_id, $filelist[$n]);
                              if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $web_id, $filelist[$n]);
                           }
                        }
                     }
@@ -296,14 +303,14 @@
            }

            // remove non-existing backups from database
            $backups = $app->db->queryAllRecords("SELECT * FROM web_backup WHERE server_id = ".$conf['server_id']);
            $backups = $app->db->queryAllRecords("SELECT * FROM web_backup WHERE server_id = ?", $conf['server_id']);
            if(is_array($backups) && !empty($backups)){
               foreach($backups as $backup){
                  $backup_file = $backup_dir.'/web'.$backup['parent_domain_id'].'/'.$backup['filename'];
                  if(!is_file($backup_file)){
                     $sql = "DELETE FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = ".$backup['parent_domain_id']." AND filename = '".$backup['filename']."'";
                     $app->db->query($sql);
                     if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                     $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                     $app->db->query($sql, $conf['server_id'], $backup['parent_domain_id'], $backup['filename']);
                     if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $backup['parent_domain_id'], $backup['filename']);
                  }
               }
            }