- don't set password via remoting if field is empty

Marius Cramer

2015-08-06 37b29231e47a0c4458dc1c15d98588f16f07e1e2

 server/lib/classes/cron.d/500-backup.inc.php

@@ -51,6 +51,7 @@
      global $app, $conf;

      $server_config = $app->getconf->get_server_config($conf['server_id'], 'server');
      $global_config = $app->getconf->get_global_config('sites');
      $backup_dir = $server_config['backup_dir'];
      $backup_mode = $server_config['backup_mode'];
      if($backup_mode == '') $backup_mode = 'userzip';
@@ -71,22 +72,15 @@
         } else {
            chmod(escapeshellcmd($backup_dir), $backup_dir_permissions);
         }
			
         //* mount backup directory, if necessary
         $run_backups = true;
         $server_config['backup_dir_mount_cmd'] = trim($server_config['backup_dir_mount_cmd']);
         if($server_config['backup_dir_is_mount'] == 'y' && $server_config['backup_dir_mount_cmd'] != ''){
            if(!$app->system->is_mounted($backup_dir)){
               exec(escapeshellcmd($server_config['backup_dir_mount_cmd']));
               sleep(1);
               if(!$app->system->is_mounted($backup_dir)) $run_backups = false;
            }
         }

            $run_backups = true;
            //* mount backup directory, if necessary
            if( $server_config['backup_dir_is_mount'] == 'y' && !$app->system->mount_backup_dir($backup_dir) ) $run_backups = false;
         if($run_backups){
            $web_array = array();
				
            //* backup only active domains
            $sql = "SELECT * FROM web_domain WHERE server_id = '".$conf['server_id']."' AND (type = 'vhost' OR type = 'vhostsubdomain' OR type = 'vhostalias') AND active = 'y'";
            $records = $app->db->queryAllRecords($sql);
            $sql = "SELECT * FROM web_domain WHERE server_id = ? AND (type = 'vhost' OR type = 'vhostsubdomain' OR type = 'vhostalias') AND active = 'y'";
            $records = $app->db->queryAllRecords($sql, $conf['server_id']);
            if(is_array($records)) {
               foreach($records as $rec) {

@@ -97,6 +91,7 @@
                     $web_user = $rec['system_user'];
                     $web_group = $rec['system_group'];
                     $web_id = $rec['domain_id'];
                     if(!in_array($web_id, $web_array)) $web_array[] = $web_id;
                     $web_backup_dir = $backup_dir.'/web'.$web_id;
                     if(!is_dir($web_backup_dir)) mkdir($web_backup_dir, 0750);
                     chmod($web_backup_dir, 0750);
@@ -131,16 +126,19 @@
                     }
                     if($retval == 0 || ($backup_mode != 'userzip' && $retval == 1) || ($backup_mode == 'userzip' && $retval == 12)) { // tar can return 1, zip can return 12(due to harmless warings) and still create valid backups  
                        if(is_file($web_backup_dir.'/'.$web_backup_file)){
                           chown($web_backup_dir.'/'.$web_backup_file, 'root');
                           chgrp($web_backup_dir.'/'.$web_backup_file, 'root');
                           $backupusername = ($global_config['backups_include_into_web_quota'] == 'y') ? $web_user : 'root';
                           $backupgroup = ($global_config['backups_include_into_web_quota'] == 'y') ? $web_group : 'root';
                           chown($web_backup_dir.'/'.$web_backup_file, $backupusername);
                           chgrp($web_backup_dir.'/'.$web_backup_file, $backupgroup);
                           chmod($web_backup_dir.'/'.$web_backup_file, 0750);

                           //* Insert web backup record in database
                           //$insert_data = "(server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",".$web_id.",'web','".$backup_mode."',".time().",'".$app->db->quote($web_backup_file)."')";
                           //$app->dbmaster->datalogInsert('web_backup', $insert_data, 'backup_id');
                           $sql = "INSERT INTO web_backup (server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",".$web_id.",'web','".$backup_mode."',".time().",'".$app->db->quote($web_backup_file)."')";
                           $app->db->query($sql);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                           $filesize = filesize($web_backup_dir.'/'.$web_backup_file);
                           $sql = "INSERT INTO web_backup (server_id, parent_domain_id, backup_type, backup_mode, tstamp, filename, filesize) VALUES (?, ?, ?, ?, ?, ?, ?)";
                           $app->db->query($sql, $conf['server_id'], $web_id, 'web', $backup_mode, time(), $web_backup_file, $filesize);
                           if($app->db->dbHost != $app->dbmaster->dbHost) 
                              $app->dbmaster->query($sql, $conf['server_id'], $web_id, 'web', $backup_mode, time(), $web_backup_file, $filesize);
                           unset($filesize);
                        }
                     } else {
                        if(is_file($web_backup_dir.'/'.$web_backup_file)) unlink($web_backup_dir.'/'.$web_backup_file);
@@ -162,14 +160,10 @@

                     for ($n = $backup_copies; $n <= 10; $n++) {
                        if(isset($files[$n]) && is_file($web_backup_dir.'/'.$files[$n])) {
                           unlink($web_backup_dir.'/'.$files[$n]);
                           //$sql = "SELECT backup_id FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($files[$n])."'";
                           //$tmp = $app->dbmaster->queryOneRecord($sql);
                           //$app->dbmaster->datalogDelete('web_backup', 'backup_id', $tmp['backup_id']);
                           //$sql = "DELETE FROM web_backup WHERE backup_id = ".intval($tmp['backup_id']);
                           $sql = "DELETE FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($files[$n])."'";
                           $app->db->query($sql);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                           $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                           $app->db->query($sql, $conf['server_id'], $web_id, $files[$n]);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'],  $web_id, $files[$n]);
                           @unlink($web_backup_dir.'/'.$files[$n]);
                        }
                     }

@@ -198,17 +192,21 @@
                     $web_user = $rec['system_user'];
                     $web_backup_dir = realpath($backup_dir.'/web'.$web_id);
                     if(is_dir($web_backup_dir)) {
                        exec('sudo -u '.escapeshellarg($web_user).' rm -f '.escapeshellarg($web_backup_dir.'/*'));
                        $sql = "DELETE FROM web_backup WHERE server_id = ".intval($conf['server_id'])." AND parent_domain_id = ".intval($web_id);
                        $app->db->query($sql);
                        if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                        $dir_handle = opendir($web_backup_dir.'/');
                        while ($file = readdir($dir_handle)) {
                           if(!is_dir($file)) {
                              unlink ("$web_backup_dir/"."$file");
                           }
                        }
                     }
                     $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ?";
                     $app->db->query($sql, $conf['server_id'], $web_id);
                     if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $web_id);
                  }
               }
            }

            $sql = "SELECT * FROM web_database WHERE server_id = ".$conf['server_id']." AND backup_interval != 'none' AND backup_interval != ''";
            $records = $app->db->queryAllRecords($sql);
            $records = $app->db->queryAllRecords("SELECT * FROM web_database WHERE server_id = ? AND backup_interval != 'none' AND backup_interval != ''", $conf['server_id']);
            if(is_array($records)) {

               include 'lib/mysql_clientdb.conf';
@@ -219,18 +217,27 @@
                  if($rec['backup_interval'] == 'daily' or ($rec['backup_interval'] == 'weekly' && date('w') == 0) or ($rec['backup_interval'] == 'monthly' && date('d') == '01')) {

                     $web_id = $rec['parent_domain_id'];
                     if(!in_array($web_id, $web_array)) $web_array[] = $web_id;
                     $db_backup_dir = $backup_dir.'/web'.$web_id;
                     if(!is_dir($db_backup_dir)) mkdir($db_backup_dir, 0750);
                     chmod($db_backup_dir, 0750);
                     chown($db_backup_dir, 'root');
                     chgrp($db_backup_dir, 'root');
                     $backupusername = 'root';
                     $backupgroup = 'root';
                     if ($global_config['backups_include_into_web_quota'] == 'y') {
                        $sql = "SELECT * FROM web_domain WHERE domain_id = ".$rec['parent_domain_id'];
                        $webdomain = $app->db->queryOneRecord($sql);
                        $backupusername = $webdomain['system_user'];
                        $backupgroup = $webdomain['system_group'];
                     }
                     chown($db_backup_dir, $backupusername);
                     chgrp($db_backup_dir, $backupgroup);

                     //* Do the mysql database backup with mysqldump
                     $db_id = $rec['database_id'];
                     $db_name = $rec['database_name'];
                     $db_backup_file = 'db_'.$db_name.'_'.date('Y-m-d_H-i').'.sql';
                     //$command = "mysqldump -h '".escapeshellcmd($clientdb_host)."' -u '".escapeshellcmd($clientdb_user)."' -p'".escapeshellcmd($clientdb_password)."' -c --add-drop-table --create-options --quick --result-file='".$db_backup_dir.'/'.$db_backup_file."' '".$db_name."'";
                     $command = "mysqldump -h ".escapeshellarg($clientdb_host)." -u ".escapeshellarg($clientdb_user)." -p".escapeshellarg($clientdb_password)." -c --add-drop-table --create-options --quick --result-file='".$db_backup_dir.'/'.$db_backup_file."' '".$db_name."'";
                     $command = "mysqldump -h ".escapeshellarg($clientdb_host)." -u ".escapeshellarg($clientdb_user)." -p".escapeshellarg($clientdb_password)." -c --add-drop-table --create-options --quick --max_allowed_packet=512M --result-file='".$db_backup_dir.'/'.$db_backup_file."' '".$db_name."'";
                     exec($command, $tmp_output, $retval);

                     //* Compress the backup with gzip
@@ -243,11 +250,12 @@
                           chgrp($db_backup_dir.'/'.$db_backup_file.'.gz', filegroup($db_backup_dir));

                           //* Insert web backup record in database
                           //$insert_data = "(server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",$web_id,'mysql','sqlgz',".time().",'".$app->db->quote($db_backup_file).".gz')";
                           //$app->dbmaster->datalogInsert('web_backup', $insert_data, 'backup_id');
                           $sql = "INSERT INTO web_backup (server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",$web_id,'mysql','sqlgz',".time().",'".$app->db->quote($db_backup_file).".gz')";
                           $app->db->query($sql);
                           if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                           $filesize = filesize($db_backup_dir.'/'.$db_backup_file.'.gz');
                           $sql = "INSERT INTO web_backup (server_id, parent_domain_id, backup_type, backup_mode, tstamp, filename, filesize) VALUES (?, ?, ?, ?, ?, ?, ?)";
                           $app->db->query($sql, $conf['server_id'], $web_id, 'mysql', 'sqlgz', time(), $db_backup_file.'.gz', $filesize);
                           if($app->db->dbHost != $app->dbmaster->dbHost) 
                              $app->dbmaster->query($sql, $conf['server_id'], $web_id, 'mysql', 'sqlgz', time(), $db_backup_file.'.gz', $filesize);
                           unset($filesize);
                        }
                     } else {
                        if(is_file($db_backup_dir.'/'.$db_backup_file.'.gz')) unlink($db_backup_dir.'/'.$db_backup_file.'.gz');
@@ -261,7 +269,7 @@
                     $dir_handle = dir($db_backup_dir);
                     $files = array();
                     while (false !== ($entry = $dir_handle->read())) {
                        if($entry != '.' && $entry != '..' && preg_match('/^db_(.*?)_\d{4}-\d{2}-\d{2}_\d{2}-\d{2}\.sql.gz$/', $entry, $matches) && is_file($db_backup_dir.'/'.$entry)) {
                        if($entry != '.' && $entry != '..' && preg_match('/^db_('.$db_name.')_\d{4}-\d{2}-\d{2}_\d{2}-\d{2}\.sql.gz$/', $entry, $matches) && is_file($db_backup_dir.'/'.$entry)) {
                           if(array_key_exists($matches[1], $files) == false) $files[$matches[1]] = array();
                           $files[$matches[1]][] = $entry;
                        }
@@ -273,13 +281,10 @@
                        rsort($filelist);
                        for ($n = $backup_copies; $n <= 10; $n++) {
                           if(isset($filelist[$n]) && is_file($db_backup_dir.'/'.$filelist[$n])) {
                              unlink($db_backup_dir.'/'.$filelist[$n]);
                              //$sql = "SELECT backup_id FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($filelist[$n])."'";
                              //$tmp = $app->dbmaster->queryOneRecord($sql);
                              //$sql = "DELETE FROM web_backup WHERE backup_id = ".intval($tmp['backup_id']);
                              $sql = "DELETE FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = $web_id AND filename = '".$app->db->quote($filelist[$n])."'";
                              $app->db->query($sql);
                              if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                              $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                              $app->db->query($sql, $conf['server_id'], $web_id, $filelist[$n]);
                              if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $web_id, $filelist[$n]);
                              @unlink($db_backup_dir.'/'.$filelist[$n]);
                           }
                        }
                     }
@@ -296,24 +301,83 @@
            }

            // remove non-existing backups from database
            $backups = $app->db->queryAllRecords("SELECT * FROM web_backup WHERE server_id = ".$conf['server_id']);
            $backups = $app->db->queryAllRecords("SELECT * FROM web_backup WHERE server_id = ?", $conf['server_id']);
            if(is_array($backups) && !empty($backups)){
               foreach($backups as $backup){
                  $backup_file = $backup_dir.'/web'.$backup['parent_domain_id'].'/'.$backup['filename'];
                  if(!is_file($backup_file)){
                     $sql = "DELETE FROM web_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = ".$backup['parent_domain_id']." AND filename = '".$backup['filename']."'";
                     $app->db->query($sql);
                     if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
                     $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                     $app->db->query($sql, $conf['server_id'], $backup['parent_domain_id'], $backup['filename']);
                  }
               }
            }
         } else {
            //* send email to admin that backup directory could not be mounted
            $global_config = $app->getconf->get_global_config('mail');
            if($global_config['admin_mail'] != ''){
               $subject = 'Backup directory '.$backup_dir.' could not be mounted';
               $message = "Backup directory ".$backup_dir." could not be mounted.\n\nThe command\n\n".$server_config['backup_dir_mount_cmd']."\n\nfailed.";
               mail($global_config['admin_mail'], $subject, $message);
            if($app->db->dbHost != $app->dbmaster->dbHost){
               $backups = $app->dbmaster->queryAllRecords("SELECT * FROM web_backup WHERE server_id = ?", $conf['server_id']);
               if(is_array($backups) && !empty($backups)){
                  foreach($backups as $backup){
                     $backup_file = $backup_dir.'/web'.$backup['parent_domain_id'].'/'.$backup['filename'];
                     if(!is_file($backup_file)){
                        $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                        $app->dbmaster->query($sql, $conf['server_id'], $backup['parent_domain_id'], $backup['filename']);
                     }
                  }
               }
            }
				
            // garbage collection (non-existing databases)
            if(is_array($web_array) && !empty($web_array)){
               foreach($web_array as $tmp_web_id){
                  $tmp_backup_dir = $backup_dir.'/web'.$tmp_web_id;
                  if(is_dir($tmp_backup_dir)){
                     $dir_handle = dir($tmp_backup_dir);
                     $files = array();
                     while (false !== ($entry = $dir_handle->read())) {
                        if($entry != '.' && $entry != '..' && preg_match('/^db_(.*?)_\d{4}-\d{2}-\d{2}_\d{2}-\d{2}\.sql.gz$/', $entry, $matches) && is_file($tmp_backup_dir.'/'.$entry)) {

                           $tmp_db_name = $matches[1];
                           $tmp_database = $app->db->queryOneRecord("SELECT * FROM web_database WHERE server_id = ? AND parent_domain_id = ? AND database_name = ?", $conf['server_id'], $tmp_web_id, $tmp_db_name);

                           if(is_array($tmp_database) && !empty($tmp_database)){
                              if($tmp_database['backup_interval'] == 'none' || intval($tmp_database['backup_copies']) == 0){
                                 @unlink($tmp_backup_dir.'/'.$entry);
                                 $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                                 $app->db->query($sql, $conf['server_id'], $tmp_web_id, $entry);
                                 if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $tmp_web_id, $entry);
                              }
                           } else {
                              @unlink($tmp_backup_dir.'/'.$entry);
                              $sql = "DELETE FROM web_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
                              $app->db->query($sql, $conf['server_id'], $tmp_web_id, $entry);
                              if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $tmp_web_id, $entry);
                           }
                        }
                     }
                     $dir_handle->close();
                  }
               }
            }
            //* end run_backups
            if( $server_config['backup_dir_is_mount'] == 'y' ) $app->system->umount_backup_dir($backup_dir);
         } 
      }
		
      // delete files from backup download dir (/var/www/example.com/backup)
      unset($records, $entry, $files);
      $sql = "SELECT * FROM web_domain WHERE server_id = ? AND (type = 'vhost' OR type = 'vhostsubdomain' OR type = 'vhostalias') AND active = 'y'";
      $records = $app->db->queryAllRecords($sql, $conf['server_id']);
      if(is_array($records)) {
         foreach($records as $rec) {
            $backup_download_dir = $rec['document_root'].'/backup';
            if(is_dir($backup_download_dir)){
               $dir_handle = dir($backup_download_dir);
               $files = array();
               while (false !== ($entry = $dir_handle->read())) {
                  if($entry != '.' && $entry != '..' && is_file($backup_download_dir.'/'.$entry)) {
                     // delete files older than 3 days
                     if(time() - filemtime($backup_download_dir.'/'.$entry) >= 60*60*24*3) @unlink($backup_download_dir.'/'.$entry);
                  }
               }
               $dir_handle->close();
            }
         }
      }