ISPConfig coding guidelines

Marius Burkard

2016-02-06 7b4df68ebbfa7edd70bc5c560c4d8aa0780e8a5b

 install/lib/installer_base.lib.php

@@ -68,6 +68,12 @@
            } else {
               $input = $autoinstall[$name];
            }
         } elseif($name != '' && $autoupdate[$name] != '') {
            if($autoupdate[$name] == 'default') {
               $input = $default;
            } else {
               $input = $autoupdate[$name];
            }
         } else {
            $answers_str = implode(',', $answers);
            swrite($this->lng($query).' ('.$answers_str.') ['.$default.']: ');
@@ -104,6 +110,12 @@
            $input = $default;
         } else {
            $input = $autoinstall[$name];
         }
      } elseif($name != '' && $autoupdate[$name] != '') {
         if($autoupdate[$name] == 'default') {
            $input = $default;
         } else {
            $input = $autoupdate[$name];
         }
      } else {
         swrite($this->lng($query).' ['.$default.']: ');
@@ -370,6 +382,84 @@
      }


   }
	
   public function detect_ips(){
      global $conf;

      exec("ip addr show | awk '/global/ { print $2 }' | cut -d '/' -f 1", $output, $retval);
		
      if($retval == 0){
         if(is_array($output) && !empty($output)){
            foreach($output as $line){
               $line = trim($line);
               $ip_type = '';
               if (filter_var($line, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
                  $ip_type = 'IPv4';
               }
               if (filter_var($line, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
                  $ip_type = 'IPv6';
               }
               if($ip_type == '') continue;
               if($this->db->dbHost != $this->dbmaster->dbHost){
                  $this->dbmaster->query('INSERT INTO server_ip (
                     sys_userid, sys_groupid, sys_perm_user, sys_perm_group,
                     sys_perm_other, server_id, client_id, ip_type, ip_address,
                     virtualhost, virtualhost_port
                  ) VALUES (
                     1,
                     1,
                     "riud",
                     "riud",
                     "",
                     ?,
                     0,
                     ?,
                     ?,
                     "y",
                     "80,443"
                  )', $conf['server_id'], $ip_type, $line);
                  $server_ip_id = $this->dbmaster->insertID();
                  $this->db->query('INSERT INTO server_ip (
                     server_php_id, sys_userid, sys_groupid, sys_perm_user, sys_perm_group,
                     sys_perm_other, server_id, client_id, ip_type, ip_address,
                     virtualhost, virtualhost_port
                  ) VALUES (
                     ?,
                     1,
                     1,
                     "riud",
                     "riud",
                     "",
                     ?,
                     0,
                     ?,
                     ?,
                     "y",
                     "80,443"
                  )', $server_ip_id, $conf['server_id'], $ip_type, $line);
               } else {
                  $this->db->query('INSERT INTO server_ip (
                     sys_userid, sys_groupid, sys_perm_user, sys_perm_group,
                     sys_perm_other, server_id, client_id, ip_type, ip_address,
                     virtualhost, virtualhost_port
                  ) VALUES (
                     1,
                     1,
                     "riud",
                     "riud",
                     "",
                     ?,
                     0,
                     ?,
                     ?,
                     "y",
                     "80,443"
                  )', $conf['server_id'], $ip_type, $line);
               }
            }
         }
      }
   }

   public function grant_master_database_rights($verbose = false) {
@@ -1391,6 +1481,27 @@


   }
	
   //** writes bind configuration files
   public function process_bind_file($configfile, $target='/', $absolute=false) {
      global $conf;

      if ($absolute) $full_file_name = $target.$configfile;
      else $full_file_name = $conf['ispconfig_install_dir'].$target.$configfile;
		
      //* Backup exiting file
      if(is_file($full_file_name)) {
         copy($full_file_name, $config_dir.$configfile.'~');
      }
      $content = rfsel($conf['ispconfig_install_dir'].'/server/conf-custom/install/'.$configfile.'.master', 'tpl/'.$configfile.'.master');
      $content = str_replace('{mysql_server_ispconfig_user}', $conf['mysql']['ispconfig_user'], $content);
      $content = str_replace('{mysql_server_ispconfig_password}', $conf['mysql']['ispconfig_password'], $content);
      $content = str_replace('{mysql_server_ispconfig_database}', $conf['mysql']['database'], $content);
      $content = str_replace('{mysql_server_ip}', $conf['mysql']['ip'], $content);
      $content = str_replace('{ispconfig_install_dir}', $conf['ispconfig_install_dir'], $content);
      $content = str_replace('{dnssec_conffile}', $conf['ispconfig_install_dir'].'/server/scripts/dnssec-config.sh', $content);
      wf($full_file_name, $content);
   }

   public function configure_bind() {
      global $conf;
@@ -1403,13 +1514,15 @@

      //* Create the slave subdirectory
      $content .= 'slave';
      if(!@is_dir($content)) mkdir($content, 2770, true);
      if(!@is_dir($content)) mkdir($content, 02770, true);

      //* Chown the slave subdirectory to $conf['bind']['bind_user']
      chown($content, $conf['bind']['bind_user']);
      chgrp($content, $conf['bind']['bind_group']);
      chmod($content, 2770);

      chmod($content, 02770);
		
      //* Install scripts for dnssec implementation
      $this->process_bind_file('named.conf.options', '/etc/bind/', true); //TODO replace hardcoded path
   }


@@ -1558,6 +1671,11 @@
         // Comment out the namevirtualhost lines, as they were added by ispconfig in ispconfig.conf file again
         replaceLine('/etc/apache2/ports.conf', 'NameVirtualHost *:80', '# NameVirtualHost *:80', 1);
         replaceLine('/etc/apache2/ports.conf', 'NameVirtualHost *:443', '# NameVirtualHost *:443', 1);
      }
		
      if(is_file('/etc/apache2/mods-available/fcgid.conf')) {
         // add or modify the parameters for fcgid.conf
         replaceLine('/etc/apache2/mods-available/fcgid.conf','MaxRequestLen','MaxRequestLen 15728640',1);
      }

      if(is_file('/etc/apache2/apache.conf')) {
@@ -2744,4 +2862,4 @@

}

?>
?>