Merge branch 'stable-3.1'

Marius Burkard

2016-07-10 e1ceb050e19c7574bca146a8da7047ee4ff456b5

 server/plugins-available/mail_plugin_dkim.inc.php

@@ -29,7 +29,7 @@
 EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 @author Florian Schaal, info@schaal-24.de
 @copyrighth Florian Schaal, info@schaal-24.de
 @copyright Florian Schaal, info@schaal-24.de
 */


@@ -75,9 +75,9 @@
    */
   function get_amavis_config() {
      $pos_config=array(
         '/etc/amavisd.conf',
         '/etc/amavisd.conf/50-user',
         '/etc/amavis/conf.d/50-user',
         '/etc/amavisd.conf',
         '/etc/amavisd/amavisd.conf'
      );
      $amavis_configfile='';
@@ -122,8 +122,8 @@
      $mail_config = $app->getconf->get_server_config($conf['server_id'], 'mail');
      if (   isset($mail_config['dkim_path']) && 
            !empty($mail_config['dkim_path']) && 
            isset($data['new']['dkim_private']) && 
            !empty($data['new']['dkim_private']) &&
//            isset($data['new']['dkim_private']) && 
//            !empty($data['new']['dkim_private']) &&
            $mail_config['dkim_path'] != '/' 
      ) {
            if (!is_dir($mail_config['dkim_path'])) {
@@ -171,22 +171,11 @@
    * This function restarts amavis
    */
    function restart_amavis() {
        global $app, $conf;
        $pos_init=array(
            $conf['init_scripts'].'/amavis',
            $conf['init_scripts'].'/amavisd'
        );
        $initfile='';
        foreach($pos_init as $init) {
            if (is_executable($init)) {
                $initfile=$init;
                break;
                }
        }
      if ( $initfile == '' ) $initfile = 'service amavis';
        $app->log('Restarting amavis: '.$initfile.'.', LOGLEVEL_DEBUG);
        exec(escapeshellarg($initfile).' restart', $output);
        foreach($output as $logline) $app->log($logline, LOGLEVEL_DEBUG);
        global $app;
      $initcommand = $app->system->getinitcommand(array('amavis', 'amavisd'), 'restart');
      $app->log('Restarting amavis: '.$initcommand.'.', LOGLEVEL_DEBUG);
      exec($initcommand, $output);
      foreach($output as $logline) $app->log($logline, LOGLEVEL_DEBUG);
    }

   /**
@@ -199,6 +188,10 @@
   function write_dkim_key($key_file, $key_value, $key_domain) {
      global $app, $mailconfig;
      $success=false;
      if ($key_file == '' || $key_value  == '' || $key_domain == '') {
         $app->log('DKIM internal error for domain '.$key_domain, LOGLEVEL_ERROR);
         return $success;
      }
      if ( $app->system->file_put_contents($key_file.'.private', $key_value) ) {
         $app->log('Saved DKIM Private-key to '.$key_file.'.private', LOGLEVEL_DEBUG);
         $success=true;
@@ -211,7 +204,7 @@
            $app->log('Saved DKIM Public to '.$key_domain.'.', LOGLEVEL_DEBUG);
         else $app->log('Unable to save DKIM Public to '.$key_domain.'.', LOGLEVEL_DEBUG);
      } else {
         $app->log('Unable to save DKIM Privte-key to '.$key_file.'.private', LOGLEVEL_ERROR);
         $app->log('Unable to save DKIM Private-key to '.$key_file.'.private', LOGLEVEL_ERROR);
      }
      return $success;
   }
@@ -325,7 +318,7 @@
               $this->remove_dkim_key($mail_config['dkim_path']."/".$data['new']['domain'], $data['new']['domain']);
            }
         } else {
            $app->log('Error saving the DKIM Private-key for '.$data['new']['domain'].' - DKIM is not enabled for the domain.', LOGLEVEL_ERROR);
            $app->log('Error saving the DKIM Private-key for '.$data['new']['domain'].' - DKIM is not enabled for the domain.', LOGLEVEL_DEBUG);
         }
      }
   }
@@ -369,44 +362,46 @@
    */
   function domain_dkim_update($event_name, $data) {
      global $app;
      if ($this->check_system($data)) {
         /* maildomain disabled */
         if ($data['new']['active'] == 'n' && $data['old']['active'] == 'y' && $data['new']['dkim']=='y') {
            $app->log('Maildomain '.$data['new']['domain'].' disabled - remove DKIM-settings', LOGLEVEL_DEBUG);
            $this->remove_dkim($data['new']);
         }
         /* maildomain re-enabled */
         if ($data['new']['active'] == 'y' && $data['old']['active'] == 'n' && $data['new']['dkim']=='y') 
            $this->add_dkim($data);

         /* maildomain active - only dkim changes */
         if ($data['new']['active'] == 'y' && $data['old']['active'] == 'y') {
            /* dkim disabled */
            if ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'n') {
      if($data['new']['dkim'] == 'y' || $data['old']['dkim'] == 'y'){
         if ($this->check_system($data)) {
            /* maildomain disabled */
            if ($data['new']['active'] == 'n' && $data['old']['active'] == 'y' && $data['new']['dkim']=='y') {
               $app->log('Maildomain '.$data['new']['domain'].' disabled - remove DKIM-settings', LOGLEVEL_DEBUG);
               $this->remove_dkim($data['new']);
            }
            /* dkim enabled */
            elseif ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'y') {
            /* maildomain re-enabled */
            if ($data['new']['active'] == 'y' && $data['old']['active'] == 'n' && $data['new']['dkim']=='y') 
               $this->add_dkim($data);
            }
            /* new private-key */
            if ($data['new']['dkim_private'] != $data['old']['dkim_private'] && $data['new']['dkim'] == 'y') {
               $this->add_dkim($data);
            }
            /* new selector */
            if ($data['new']['dkim_selector'] != $data['old']['dkim_selector'] && $data['new']['dkim'] == 'y') {
               $this->add_dkim($data);
            }
            /* new domain-name */
            if ($data['new']['domain'] != $data['old']['domain']) {
               $this->remove_dkim($data['old']);
               $this->add_dkim($data);
            }
         }

         /* resync */
         if ($data['new']['active'] == 'y' && $data['new'] == $data['old']) {
            $this->add_dkim($data);
            /* maildomain active - only dkim changes */
            if ($data['new']['active'] == 'y' && $data['old']['active'] == 'y') {
               /* dkim disabled */
               if ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'n') {
                  $this->remove_dkim($data['new']);
               }
               /* dkim enabled */
               elseif ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'y') {
                  $this->add_dkim($data);
               }
               /* new private-key */
               if ($data['new']['dkim_private'] != $data['old']['dkim_private'] && $data['new']['dkim'] == 'y') {
                  $this->add_dkim($data);
               }
               /* new selector */
               if ($data['new']['dkim_selector'] != $data['old']['dkim_selector'] && $data['new']['dkim'] == 'y') {
                  $this->add_dkim($data);
               }
               /* new domain-name */
               if ($data['new']['domain'] != $data['old']['domain']) {
                  $this->remove_dkim($data['old']);
                  $this->add_dkim($data);
               }
            }

            /* resync */
            if ($data['new']['active'] == 'y' && $data['new'] == $data['old'] && $data['new']['dkim']=='y') {
               $this->add_dkim($data);
            }
         }
      }
   }