From 1370d424a794ec191966b81f4f975161a38895dc Mon Sep 17 00:00:00 2001 From: Marcin Floryan <marcin.floryan@gmail.com> Date: Fri, 02 Nov 2012 17:03:49 -0400 Subject: [PATCH] A failure to download dependencies fails the build. Otherwise we proceed with lots of errors anyway. --- src/com/gitblit/AuthenticationFilter.java | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/gitblit/AuthenticationFilter.java b/src/com/gitblit/AuthenticationFilter.java index caa8a07..4762c42 100644 --- a/src/com/gitblit/AuthenticationFilter.java +++ b/src/com/gitblit/AuthenticationFilter.java @@ -103,7 +103,7 @@ String credentials = new String(Base64.decode(base64Credentials), Charset.forName("UTF-8")); // credentials = username:password - final String[] values = credentials.split(":"); + final String[] values = credentials.split(":",2); if (values.length == 2) { String username = values[0]; @@ -170,6 +170,7 @@ public AuthenticatedRequest(HttpServletRequest req) { super(req); user = new UserModel("anonymous"); + user.isAuthenticated = false; } UserModel getUser() { @@ -188,7 +189,7 @@ @Override public boolean isUserInRole(String role) { if (role.equals(Constants.ADMIN_ROLE)) { - return user.canAdmin; + return user.canAdmin(); } // Gitblit does not currently use actual roles in the traditional // servlet container sense. That is the reason this is marked -- Gitblit v1.9.1