From 1aec17636d8c548257cb307f8cc1e41354e00421 Mon Sep 17 00:00:00 2001 From: marco <mw.sunshine@gmx.de> Date: Mon, 23 Nov 2015 13:58:14 -0500 Subject: [PATCH] Fix 2 possible NullPointer occurences --- src/main/java/com/gitblit/utils/FileUtils.java | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/src/main/java/com/gitblit/utils/FileUtils.java b/src/main/java/com/gitblit/utils/FileUtils.java index e7f0104..ad2509d 100644 --- a/src/main/java/com/gitblit/utils/FileUtils.java +++ b/src/main/java/com/gitblit/utils/FileUtils.java @@ -140,9 +140,10 @@ public static String readContent(File file, String lineEnding) { StringBuilder sb = new StringBuilder(); InputStreamReader is = null; + BufferedReader reader = null; try { is = new InputStreamReader(new FileInputStream(file), Charset.forName("UTF-8")); - BufferedReader reader = new BufferedReader(is); + reader = new BufferedReader(is); String line = null; while ((line = reader.readLine()) != null) { sb.append(line); @@ -154,6 +155,14 @@ System.err.println("Failed to read content of " + file.getAbsolutePath()); t.printStackTrace(); } finally { + if (reader != null){ + try { + reader.close(); + } catch (IOException ioe) { + System.err.println("Failed to close file " + file.getAbsolutePath()); + ioe.printStackTrace(); + } + } if (is != null) { try { is.close(); -- Gitblit v1.9.1