From 1d78b8b372f15d89f10fd32cb0227a6a7966de3c Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 17 Apr 2014 23:08:07 -0400 Subject: [PATCH] [findbugs] Clarify class used for resource loading --- src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java b/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java index 37649ea..6f8f95a 100644 --- a/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java +++ b/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java @@ -518,7 +518,7 @@ if (gitblit.installPlugin(urlOrId, !disableChecksum)) { stdout.println(String.format("Installed %s", urlOrId)); } else { - new UnloggedFailure(1, String.format("Failed to install %s", urlOrId)); + throw new UnloggedFailure(1, String.format("Failed to install %s", urlOrId)); } } else { PluginRelease pr = gitblit.lookupRelease(urlOrId, version); @@ -614,7 +614,7 @@ throw new UnloggedFailure(String.format("Plugin %s is not installed!", id)); } - if (gitblit.deletePlugin(pluginWrapper.getPluginId())) { + if (gitblit.uninstallPlugin(pluginWrapper.getPluginId())) { stdout.println(String.format("Uninstalled %s", pluginWrapper.getPluginId())); } else { throw new UnloggedFailure(1, String.format("Failed to uninstall %s", pluginWrapper.getPluginId())); -- Gitblit v1.9.1