From 2a7306a1d92522569a8bb6e5a7c0bcdd5cf4cfaa Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 26 May 2011 17:11:38 -0400 Subject: [PATCH] Findbugs. CodePro Audit. Checkstyle. Unit test refactoring. --- src/com/gitblit/utils/StringUtils.java | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/com/gitblit/utils/StringUtils.java b/src/com/gitblit/utils/StringUtils.java index 808508d..4a9c88d 100644 --- a/src/com/gitblit/utils/StringUtils.java +++ b/src/com/gitblit/utils/StringUtils.java @@ -20,7 +20,6 @@ import java.security.NoSuchAlgorithmException; import java.util.List; - public class StringUtils { public static boolean isEmpty(String value) { @@ -47,8 +46,9 @@ retStr.append(" "); } else if (changeSpace && inStr.charAt(i) == '\t') { retStr.append(" "); - } else + } else { retStr.append(inStr.charAt(i)); + } i++; } return retStr.toString(); @@ -117,8 +117,9 @@ byte[] sha1hash = md.digest(); StringBuilder sb = new StringBuilder(sha1hash.length * 2); for (int i = 0; i < sha1hash.length; i++) { - if (((int) sha1hash[i] & 0xff) < 0x10) - sb.append("0"); + if (((int) sha1hash[i] & 0xff) < 0x10) { + sb.append('0'); + } sb.append(Long.toString((int) sha1hash[i] & 0xff, 16)); } return sb.toString(); @@ -126,7 +127,7 @@ throw new RuntimeException(t); } } - + public static String getRootPath(String path) { if (path.indexOf('/') > -1) { return path.substring(0, path.indexOf('/')); -- Gitblit v1.9.1