From 2a7306a1d92522569a8bb6e5a7c0bcdd5cf4cfaa Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 26 May 2011 17:11:38 -0400 Subject: [PATCH] Findbugs. CodePro Audit. Checkstyle. Unit test refactoring. --- src/com/gitblit/wicket/pages/RepositoriesPage.java | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/com/gitblit/wicket/pages/RepositoriesPage.java b/src/com/gitblit/wicket/pages/RepositoriesPage.java index 792fd95..2bb818d 100644 --- a/src/com/gitblit/wicket/pages/RepositoriesPage.java +++ b/src/com/gitblit/wicket/pages/RepositoriesPage.java @@ -41,14 +41,14 @@ setupPage("", ""); final boolean showAdmin; - if (GitBlit.self().settings().getBoolean(Keys.web.authenticateAdminPages, true)) { - boolean allowAdmin = GitBlit.self().settings().getBoolean(Keys.web.allowAdministration, false); + if (GitBlit.getBoolean(Keys.web.authenticateAdminPages, true)) { + boolean allowAdmin = GitBlit.getBoolean(Keys.web.allowAdministration, false); showAdmin = allowAdmin && GitBlitWebSession.get().canAdmin(); // authentication requires state and session setStatelessHint(false); } else { - showAdmin = GitBlit.self().settings().getBoolean(Keys.web.allowAdministration, false); - if (GitBlit.self().settings().getBoolean(Keys.web.authenticateViewPages, false)) { + showAdmin = GitBlit.getBoolean(Keys.web.allowAdministration, false); + if (GitBlit.getBoolean(Keys.web.authenticateViewPages, false)) { // authentication requires state and session setStatelessHint(false); } else { @@ -64,7 +64,7 @@ } // Load the markdown welcome message - String messageSource = GitBlit.self().settings().getString(Keys.web.repositoriesMessage, "gitblit"); + String messageSource = GitBlit.getString(Keys.web.repositoriesMessage, "gitblit"); String message = "<br/>"; if (messageSource.equalsIgnoreCase("gitblit")) { // Read default welcome message @@ -94,9 +94,10 @@ } } } - Component repositoriesMessage = new Label("repositoriesMessage", message).setEscapeModelStrings(false); + Component repositoriesMessage = new Label("repositoriesMessage", message) + .setEscapeModelStrings(false); add(repositoriesMessage); - add(new RepositoriesPanel("repositoriesPanel", showAdmin, getAccessRestrictions())); + add(new RepositoriesPanel("repositoriesPanel", showAdmin, getAccessRestrictions())); add(new UsersPanel("usersPanel", showAdmin).setVisible(showAdmin)); } } -- Gitblit v1.9.1