From 30f9d25d77ccb5cd978d4cf8fa389ec819e90e95 Mon Sep 17 00:00:00 2001 From: Philip L. McMahon <philip.l.mcmahon@gmail.com> Date: Fri, 27 Jan 2012 02:02:19 -0500 Subject: [PATCH] Correct update of HEAD symbolic reference when target is a tag. --- src/com/gitblit/wicket/pages/PatchPage.java | 30 ++++++++++++++++++++++-------- 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/com/gitblit/wicket/pages/PatchPage.java b/src/com/gitblit/wicket/pages/PatchPage.java index 62431d2..0493473 100644 --- a/src/com/gitblit/wicket/pages/PatchPage.java +++ b/src/com/gitblit/wicket/pages/PatchPage.java @@ -1,3 +1,18 @@ +/* + * Copyright 2011 gitblit.com. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package com.gitblit.wicket.pages; import org.apache.wicket.PageParameters; @@ -7,6 +22,7 @@ import org.eclipse.jgit.revwalk.RevCommit; import com.gitblit.GitBlit; +import com.gitblit.utils.DiffUtils; import com.gitblit.utils.JGitUtils; import com.gitblit.utils.StringUtils; import com.gitblit.wicket.GitBlitWebSession; @@ -22,7 +38,7 @@ redirectToInterceptPage(new RepositoriesPage()); return; } - + final String repositoryName = WicketUtils.getRepositoryName(params); final String baseObjectId = WicketUtils.getBaseObjectId(params); final String objectId = WicketUtils.getObject(params); @@ -41,14 +57,12 @@ redirectToInterceptPage(new RepositoriesPage()); return; } - - String patch; - if (StringUtils.isEmpty(baseObjectId)) { - patch = JGitUtils.getCommitPatch(r, commit, blobPath); - } else { - RevCommit baseCommit = JGitUtils.getCommit(r, baseObjectId); - patch = JGitUtils.getCommitPatch(r, baseCommit, commit, blobPath); + + RevCommit baseCommit = null; + if (!StringUtils.isEmpty(baseObjectId)) { + baseCommit = JGitUtils.getCommit(r, baseObjectId); } + String patch = DiffUtils.getCommitPatch(r, baseCommit, commit, blobPath); add(new Label("patchText", patch)); r.close(); } -- Gitblit v1.9.1