From 498cdca0cc3a7545311877a0fb43586ef113a801 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Sat, 05 Jul 2014 12:27:17 -0400 Subject: [PATCH] Fix possible NPE in RawServlet --- src/main/java/com/gitblit/auth/WindowsAuthProvider.java | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/gitblit/auth/WindowsAuthProvider.java b/src/main/java/com/gitblit/auth/WindowsAuthProvider.java index 93cae04..ac15b28 100644 --- a/src/main/java/com/gitblit/auth/WindowsAuthProvider.java +++ b/src/main/java/com/gitblit/auth/WindowsAuthProvider.java @@ -158,9 +158,11 @@ groupNames.add(group.getFqn()); } - if (groupNames.contains("BUILTIN\\Administrators")) { - // local administrator - user.canAdmin = true; + if (settings.getBoolean(Keys.realm.windows.permitBuiltInAdministrators, true)) { + if (groupNames.contains("BUILTIN\\Administrators")) { + // local administrator + user.canAdmin = true; + } } // TODO consider mapping Windows groups to teams -- Gitblit v1.9.1