From 66c29a66638066c3c56cdcbd423d5c7874b73a27 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Mon, 11 Apr 2011 09:59:56 -0400
Subject: [PATCH] Enforce default paging value.

---
 src/com/gitblit/wicket/RepositoryPage.java |   22 ++++++++--------------
 1 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/src/com/gitblit/wicket/RepositoryPage.java b/src/com/gitblit/wicket/RepositoryPage.java
index 1a764a3..4e84938 100644
--- a/src/com/gitblit/wicket/RepositoryPage.java
+++ b/src/com/gitblit/wicket/RepositoryPage.java
@@ -21,19 +21,19 @@
 public abstract class RepositoryPage extends BasePage {
 
 	protected final String repositoryName;
-	protected final String commitId;
+	protected final String objectId;
 	protected String description;
 
 	private transient Repository r = null;
 
 	public RepositoryPage(PageParameters params) {
 		super(params);
-		if (!params.containsKey("p")) {
+		if (!params.containsKey("r")) {
 			error("Repository not specified!");
 			redirectToInterceptPage(new RepositoriesPage());
 		}
-		repositoryName = params.getString("p", "");
-		commitId = params.getString("h", "");
+		repositoryName = params.getString("r", "");
+		objectId = params.getString("h", "HEAD");
 
 		Repository r = getRepository();
 
@@ -112,24 +112,18 @@
 	}
 
 	protected PageParameters newRepositoryParameter() {
-		return new PageParameters("p=" + repositoryName);
+		return WicketUtils.newRepositoryParameter(repositoryName);
 	}
 
 	protected PageParameters newCommitParameter() {
-		return newCommitParameter(commitId);
+		return WicketUtils.newObjectParameter(repositoryName, objectId);
 	}
 
 	protected PageParameters newCommitParameter(String commitId) {
-		if (commitId == null || commitId.trim().length() == 0) {
-			return newRepositoryParameter();
-		}
-		return new PageParameters("p=" + repositoryName + ",h=" + commitId);
+		return WicketUtils.newObjectParameter(repositoryName, commitId);
 	}
 
 	protected PageParameters newPathParameter(String path) {
-		if (path == null || path.trim().length() == 0) {
-			return newCommitParameter();
-		}
-		return new PageParameters("p=" + repositoryName + ",h=" + commitId + ",f=" + path);
+		return WicketUtils.newPathParameter(repositoryName, objectId, path);
 	}
 }

--
Gitblit v1.9.1