From 68fb1791fa8033d464d50e45481d04c3e3d0a025 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 17 Apr 2014 23:08:07 -0400 Subject: [PATCH] [findbugs] Add null check when testing if a user is disabled in SessionPage --- src/main/java/com/gitblit/wicket/pages/EditTicketPage.java | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java b/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java index 00cd47d..64c0648 100644 --- a/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java +++ b/src/main/java/com/gitblit/wicket/pages/EditTicketPage.java @@ -101,6 +101,9 @@ || !currentUser.canEdit(ticket, getRepositoryModel()) || !app().tickets().isAcceptingTicketUpdates(getRepositoryModel())) { setResponsePage(TicketsPage.class, WicketUtils.newObjectParameter(repositoryName, "" + ticketId)); + + // create a placeholder object so we don't trigger NPEs + ticket = new TicketModel(); } typeModel = Model.of(ticket.type); -- Gitblit v1.9.1