From 6b254fe9f76c202065153ac045859b8434c81c73 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Thu, 17 Apr 2014 23:08:07 -0400
Subject: [PATCH] [findbugs] Fix Selenium test
---
src/test/java/de/akquinet/devops/test/ui/view/RepoEditView.java | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/test/java/de/akquinet/devops/test/ui/view/RepoEditView.java b/src/test/java/de/akquinet/devops/test/ui/view/RepoEditView.java
index a3365d1..0309bce 100644
--- a/src/test/java/de/akquinet/devops/test/ui/view/RepoEditView.java
+++ b/src/test/java/de/akquinet/devops/test/ui/view/RepoEditView.java
@@ -24,9 +24,9 @@
/**
* class representing the tabs you can access when you edit a repo.
- *
+ *
* @author saheba
- *
+ *
*/
public class RepoEditView extends GitblitDashboardView {
@@ -60,7 +60,6 @@
String linkText = "access permissions";
List<WebElement> found = getDriver().findElements(
By.partialLinkText(linkText));
- System.out.println("PERM TABS found =" + found.size());
if (found != null && found.size() == 1) {
found.get(0).click();
return true;
@@ -119,12 +118,11 @@
String xpath = "//input[@name =\"authorizationControl\" and @value=\""
+ option + "\"]";
List<WebElement> found = getDriver().findElements(By.xpath(xpath));
- System.out.println("found auth CONTROL options " + found.size());
- if (found == null || found.size() == 0 || found.size() > 1) {
- return false;
+ if (found != null && found.size() == 1) {
+ found.get(0).click();
+ return true;
}
- found.get(0).click();
- return true;
+ return false;
}
private boolean isPermissionViewDisabled(String prefix, String view) {
--
Gitblit v1.9.1