From 70a0c76b7eef4da44eb14dfef8db106389a8940e Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Fri, 29 Mar 2013 09:35:06 -0400
Subject: [PATCH] Ensure Redmine url is properly formatted (issue 223)

---
 src/main/java/com/gitblit/RedmineUserService.java |    2 +-
 releases.moxie                                    |   24 +++++++++++++++++-------
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/releases.moxie b/releases.moxie
index 6a61d28..74c6fc1 100644
--- a/releases.moxie
+++ b/releases.moxie
@@ -13,28 +13,38 @@
 	 - Do not queue emails with no recipients (issue 201)
 	 - Disable view and blame links for deleted blobs (issue 216)
 	 - Fixed extracting Groovy scripts on Express installs (issue 220)
+	 - Ensure Redmine url is properly formatted (issue 223)
 	 - Use standard ServletRequestWrapper instead of custom wrapper (issue 224)
 
     additions: 
-	 - Option to force client-side basic authentication instead of form-based authentication if web.authenticateViewPages=true (issue 222)
-	 - Added weblogic.xml to WAR for deployment on WebLogic (issue 199)
      - Optional periodic LDAP user and team pre-fetching & synchronization
      - Display name and version in Tomcat Manager
      - FogBugz post-receive hook script
      - Implemented multiple repository owners
      - Chinese translation
+	 - Added weblogic.xml to WAR for deployment on WebLogic (issue 199)
+	 - Option to force client-side basic authentication instead of form-based authentication if web.authenticateViewPages=true (issue 222)
 
     contributors:
+	- Bandarupalli Satyanarayana
 	- Christian Aistleitner
+	- Egbert Teeselink
+	- Hige Maniya
+	- Ikslawek
 	- Jay Meyer
+	- John Crygier
+	- Laurens Vrijnsen
+	- Martijn Laan
+	- Michael Schaefers
+	- Philip Boutros
+	- Rafael Cavazin
+	- Ryan Schneider
+	- Sarah Haselbauer
 	- Slawomir Bochenski
-	- github/furinzen
-    - github/mschaefers
-    - github/thefake
-    - github/djschny
+	- Stardrad Yin
+	- Thomas Pummer
     - github/akquinet
     - github/dapengme
-    - github/yin8086
 }
 
 #
diff --git a/src/main/java/com/gitblit/RedmineUserService.java b/src/main/java/com/gitblit/RedmineUserService.java
index 9d571e3..2728e00 100644
--- a/src/main/java/com/gitblit/RedmineUserService.java
+++ b/src/main/java/com/gitblit/RedmineUserService.java
@@ -158,7 +158,7 @@
 
         String url = this.settings.getString(Keys.realm.redmine.url, "");
         if (!url.endsWith("/")) {
-        	url.concat("/");
+        	url = url.concat("/");
         }
         HttpURLConnection http;
         if (username == null) {

--
Gitblit v1.9.1