From 7847af6e63e7adef6ec8d99a1809e91472d2bc2d Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 05 Sep 2013 09:14:22 -0400 Subject: [PATCH] Restore blockpush and localclone hooks to binaries (issue-303) --- src/main/java/com/gitblit/wicket/pages/BlamePage.java | 27 +++++++++++++++++++-------- 1 files changed, 19 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/BlamePage.java b/src/main/java/com/gitblit/wicket/pages/BlamePage.java index 74e25be..53bd233 100644 --- a/src/main/java/com/gitblit/wicket/pages/BlamePage.java +++ b/src/main/java/com/gitblit/wicket/pages/BlamePage.java @@ -27,6 +27,7 @@ import org.apache.wicket.markup.repeater.data.DataView; import org.apache.wicket.markup.repeater.data.ListDataProvider; import org.eclipse.jgit.lib.Constants; +import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.revwalk.RevCommit; import com.gitblit.GitBlit; @@ -36,11 +37,14 @@ import com.gitblit.utils.DiffUtils; import com.gitblit.utils.JGitUtils; import com.gitblit.utils.StringUtils; +import com.gitblit.wicket.CacheControl; +import com.gitblit.wicket.CacheControl.LastModified; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.panels.CommitHeaderPanel; import com.gitblit.wicket.panels.LinkPanel; import com.gitblit.wicket.panels.PathBreadcrumbsPanel; +@CacheControl(LastModified.BOOT) public class BlamePage extends RepositoryPage { public BlamePage(PageParameters params) { @@ -96,6 +100,7 @@ private int count; private String lastCommitId = ""; private boolean showInitials = true; + private String zeroId = ObjectId.zeroId().getName(); public void populateItem(final Item<AnnotatedLine> item) { AnnotatedLine entry = item.getModelObject(); @@ -105,14 +110,20 @@ if (!lastCommitId.equals(entry.commitId)) { lastCommitId = entry.commitId; count++; - // show the link for first line - LinkPanel commitLink = new LinkPanel("commit", null, - getShortObjectId(entry.commitId), CommitPage.class, - newCommitParameter(entry.commitId)); - WicketUtils.setHtmlTooltip(commitLink, - MessageFormat.format("{0}, {1}", entry.author, df.format(entry.when))); - item.add(commitLink); - showInitials = true; + if (zeroId.equals(entry.commitId)) { + // unknown commit + item.add(new Label("commit", "<?>")); + showInitials = false; + } else { + // show the link for first line + LinkPanel commitLink = new LinkPanel("commit", null, + getShortObjectId(entry.commitId), CommitPage.class, + newCommitParameter(entry.commitId)); + WicketUtils.setHtmlTooltip(commitLink, + MessageFormat.format("{0}, {1}", entry.author, df.format(entry.when))); + item.add(commitLink); + showInitials = true; + } } else { if (showInitials) { showInitials = false; -- Gitblit v1.9.1