From 8198d218935f649ada4f1e9dbc2e7bfe377a1388 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Thu, 20 Jun 2013 17:26:03 -0400
Subject: [PATCH] Set rel="nofollow" on compressed download links
---
src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java | 3 ++-
releases.moxie | 11 ++++++-----
src/main/java/com/gitblit/wicket/panels/LinkPanel.java | 6 ++++++
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/releases.moxie b/releases.moxie
index 4d2e875..74e7d14 100644
--- a/releases.moxie
+++ b/releases.moxie
@@ -41,6 +41,7 @@
- Properly set application/json content-type on api calls
- Make days back filter choices a setting
- Changed default days back filter setting to 7 days
+ - Set rel="nofollow" on compressed download links
- Improved page title
- Updated Polish translation
- Updated Japanese translation
@@ -71,7 +72,7 @@
contributors:
- Bandarupalli Satyanarayana
- - Chad H.
+ - Chad Horohoe
- Christian Aistleitner
- David Ostrovsky
- Egbert Teeselink
@@ -86,7 +87,7 @@
- Lukasz Jader
- Martijn Laan
- Matthias Bauer
- - Micha�l Pailloncy
+ - Michael Pailloncy
- Michael Schaefers
- Oliver Doepner
- Philip Boutros
@@ -99,14 +100,14 @@
- Thomas Pummer
- William Whittle
- Yukihiko Sawanobori
- - github/akquinet
- - github/dapengme
+ - github/akquinet
+ - github/dapengme
dependencyChanges:
- JGit 3.0.0-SNAPSHOT
- Iconic font
- AngularJS 1.0.7
- - FreeMarker 2.3.19
+ - FreeMarker 2.3.19
settings:
- { name: 'git.daemonBindInterface', defaultValue: 'localhost' }
diff --git a/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java b/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java
index b22c758..122ae55 100644
--- a/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java
+++ b/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java
@@ -60,7 +60,8 @@
String href = DownloadZipServlet.asLink(baseUrl, repositoryName,
objectId, path, format);
- Component c = new LinkPanel("compressedLink", null, format.name(), href);
+ LinkPanel c = new LinkPanel("compressedLink", null, format.name(), href);
+ c.setNoFollow();
item.add(c);
Label lb = new Label("linkSep", "|");
lb.setVisible(counter > 0);
diff --git a/src/main/java/com/gitblit/wicket/panels/LinkPanel.java b/src/main/java/com/gitblit/wicket/panels/LinkPanel.java
index 688a957..21470b2 100644
--- a/src/main/java/com/gitblit/wicket/panels/LinkPanel.java
+++ b/src/main/java/com/gitblit/wicket/panels/LinkPanel.java
@@ -15,6 +15,7 @@
*/
package com.gitblit.wicket.panels;
+import org.apache.wicket.Component;
import org.apache.wicket.PageParameters;
import org.apache.wicket.behavior.SimpleAttributeModifier;
import org.apache.wicket.markup.html.WebPage;
@@ -106,5 +107,10 @@
link.add(new Label("label", labelModel));
add(link);
}
+
+ public void setNoFollow() {
+ Component c = get("link");
+ c.add(new SimpleAttributeModifier("rel", "nofollow"));
+ }
}
--
Gitblit v1.9.1