From 8f6e672ffe19c439aadc07b64e36ae4b83e78f1e Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Mon, 15 Jul 2013 08:09:20 -0400 Subject: [PATCH] Fixed url panel failure when there are no repository urls (issue 269) --- releases.moxie | 3 ++- src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/releases.moxie b/releases.moxie index d9e3035..3f07613 100644 --- a/releases.moxie +++ b/releases.moxie @@ -9,7 +9,8 @@ html: ~ text: ~ security: ~ - fixes: ~ + fixes: + - Gitblit-as-viewer with no repository urls failed to display summary page (issue 269) changes: ~ additions: ~ dependencyChanges: ~ diff --git a/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java b/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java index 3711ca9..aaab2b1 100644 --- a/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java +++ b/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java @@ -85,7 +85,7 @@ // grab primary url from the top of the list primaryUrl = repositoryUrls.size() == 0 ? null : repositoryUrls.get(0); - boolean canClone = ((primaryUrl.permission == null) || primaryUrl.permission.atLeast(AccessPermission.CLONE)); + boolean canClone = primaryUrl != null && ((primaryUrl.permission == null) || primaryUrl.permission.atLeast(AccessPermission.CLONE)); if (repositoryUrls.size() == 0 || !canClone) { // no urls, nothing to show. -- Gitblit v1.9.1