From 9fcd4fa469c4154a6f5f82d08877336a5114e538 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Fri, 21 Feb 2014 09:05:42 -0500
Subject: [PATCH] Remove admin permission setting from Redmine auth provider (issue-368)
---
src/main/java/com/gitblit/auth/RedmineAuthProvider.java | 5 -----
releases.moxie | 1 +
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/releases.moxie b/releases.moxie
index 6548713..a533977 100644
--- a/releases.moxie
+++ b/releases.moxie
@@ -21,6 +21,7 @@
- Fixed NPE when attempting to add a permission without a registrant (issue-344)
- Invalidate all cached repository data on "clear cache" (issue-346)
- Fix chart failures when an apostrophe is in a user display name (issue-350, pr-128)
+ - Stop setting admin permission based on undocumented Redmine REST API behavior (issue-368)
- Fix support url decoding with non-ascii characters (pr-136)
- Fix potential NPE on removing uncached repository from cache
- Ignore the default contents of .git/description file
diff --git a/src/main/java/com/gitblit/auth/RedmineAuthProvider.java b/src/main/java/com/gitblit/auth/RedmineAuthProvider.java
index 04adc45..7e957ec 100644
--- a/src/main/java/com/gitblit/auth/RedmineAuthProvider.java
+++ b/src/main/java/com/gitblit/auth/RedmineAuthProvider.java
@@ -134,11 +134,6 @@
user.displayName = current.user.firstname + " " + current.user.lastname;
user.emailAddress = current.user.mail;
user.password = Constants.EXTERNAL_ACCOUNT;
- if (!StringUtils.isEmpty(current.user.login)) {
- // only admin users can get login name
- // evidently this is an undocumented behavior of Redmine
- user.canAdmin = true;
- }
// TODO consider Redmine group mapping for team membership
// http://www.redmine.org/projects/redmine/wiki/Rest_Users
--
Gitblit v1.9.1