From a70b43cde76b4baab82b4ce0d9ff82883f80b8df Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Wed, 26 Oct 2011 17:54:07 -0400
Subject: [PATCH] Added status icon

---
 src/com/gitblit/SyndicationServlet.java |   92 +++++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 82 insertions(+), 10 deletions(-)

diff --git a/src/com/gitblit/SyndicationServlet.java b/src/com/gitblit/SyndicationServlet.java
index d2b396e..f1c474f 100644
--- a/src/com/gitblit/SyndicationServlet.java
+++ b/src/com/gitblit/SyndicationServlet.java
@@ -15,6 +15,7 @@
  */
 package com.gitblit;
 
+import java.text.MessageFormat;
 import java.util.List;
 
 import javax.servlet.http.HttpServlet;
@@ -25,31 +26,102 @@
 import org.slf4j.LoggerFactory;
 
 import com.gitblit.models.RepositoryModel;
+import com.gitblit.utils.HttpUtils;
 import com.gitblit.utils.JGitUtils;
 import com.gitblit.utils.StringUtils;
 import com.gitblit.utils.SyndicationUtils;
 
+/**
+ * SyndicationServlet generates RSS 2.0 feeds and feed links.
+ * 
+ * Access to this servlet is protected by the SyndicationFilter.
+ * 
+ * @author James Moger
+ * 
+ */
 public class SyndicationServlet extends HttpServlet {
 
 	private static final long serialVersionUID = 1L;
 
 	private transient Logger logger = LoggerFactory.getLogger(SyndicationServlet.class);
 
+	/**
+	 * Create a feed link for the specified repository and branch/tag/commit id.
+	 * 
+	 * @param baseURL
+	 * @param repository
+	 *            the repository name
+	 * @param objectId
+	 *            the branch, tag, or first commit for the feed
+	 * @param length
+	 *            the number of commits to include in the feed
+	 * @return an RSS feed url
+	 */
 	public static String asLink(String baseURL, String repository, String objectId, int length) {
-		if (baseURL.charAt(baseURL.length() - 1) == '/') {
+		if (baseURL.length() > 0 && baseURL.charAt(baseURL.length() - 1) == '/') {
 			baseURL = baseURL.substring(0, baseURL.length() - 1);
 		}
-		return baseURL + Constants.SYNDICATION_SERVLET_PATH + "?r=" + repository
-				+ (objectId == null ? "" : ("&h=" + objectId)) + (length > 0 ? "&l=" + length : "");
+		StringBuilder url = new StringBuilder();
+		url.append(baseURL);
+		url.append(Constants.SYNDICATION_PATH);
+		url.append(repository);
+		if (!StringUtils.isEmpty(objectId) || length > 0) {
+			StringBuilder parameters = new StringBuilder("?");
+			if (StringUtils.isEmpty(objectId)) {
+				parameters.append("l=");
+				parameters.append(length);
+			} else {
+				parameters.append("h=");
+				parameters.append(objectId);
+				if (length > 0) {
+					parameters.append("&l=");
+					parameters.append(length);
+				}
+			}
+			url.append(parameters);
+		}
+		return url.toString();
 	}
 
+	/**
+	 * Determines the appropriate title for a feed.
+	 * 
+	 * @param repository
+	 * @param objectId
+	 * @return title of the feed
+	 */
+	public static String getTitle(String repository, String objectId) {
+		String id = objectId;
+		if (!StringUtils.isEmpty(id)) {
+			if (id.startsWith(org.eclipse.jgit.lib.Constants.R_HEADS)) {
+				id = id.substring(org.eclipse.jgit.lib.Constants.R_HEADS.length());
+			} else if (id.startsWith(org.eclipse.jgit.lib.Constants.R_REMOTES)) {
+				id = id.substring(org.eclipse.jgit.lib.Constants.R_REMOTES.length());
+			} else if (id.startsWith(org.eclipse.jgit.lib.Constants.R_TAGS)) {
+				id = id.substring(org.eclipse.jgit.lib.Constants.R_TAGS.length());
+			}
+		}
+		return MessageFormat.format("{0} ({1})", repository, id);
+	}
+
+	/**
+	 * Generates the feed content.
+	 * 
+	 * @param request
+	 * @param response
+	 * @throws javax.servlet.ServletException
+	 * @throws java.io.IOException
+	 */
 	private void processRequest(javax.servlet.http.HttpServletRequest request,
 			javax.servlet.http.HttpServletResponse response) throws javax.servlet.ServletException,
 			java.io.IOException {
-		String hostUrl = request.getRequestURL().toString();
-		String servlet = request.getServletPath();
-		hostUrl = hostUrl.substring(0, hostUrl.indexOf(servlet));
-		String repositoryName = request.getParameter("r");
+
+		String servletUrl = request.getContextPath() + request.getServletPath();
+		String url = request.getRequestURI().substring(servletUrl.length());
+		if (url.charAt(0) == '/' && url.length() > 1) {
+			url = url.substring(1);
+		}
+		String repositoryName = url;
 		String objectId = request.getParameter("h");
 		String l = request.getParameter("l");
 		int length = GitBlit.getInteger(Keys.web.syndicationEntries, 25);
@@ -62,14 +134,14 @@
 			} catch (NumberFormatException x) {
 			}
 		}
-		
-		// TODO confirm repository is accessible!!
 
+		response.setContentType("application/rss+xml; charset=UTF-8");
 		Repository repository = GitBlit.self().getRepository(repositoryName);
 		RepositoryModel model = GitBlit.self().getRepositoryModel(repositoryName);
 		List<RevCommit> commits = JGitUtils.getRevLog(repository, objectId, 0, length);
 		try {
-			SyndicationUtils.toRSS(hostUrl, model.name + " " + objectId, model.description, model.name, commits, response.getOutputStream());
+			SyndicationUtils.toRSS(HttpUtils.getGitblitURL(request), getTitle(model.name, objectId), model.description,
+					model.name, commits, response.getOutputStream());
 		} catch (Exception e) {
 			logger.error("An error occurred during feed generation", e);
 		}

--
Gitblit v1.9.1