From c3f4f124f1b9e45d7696f3c16f958d1c81ff280a Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Thu, 21 Apr 2011 21:46:47 -0400 Subject: [PATCH] Use markdown for welcome message. Simplify login page appearance. --- src/com/gitblit/wicket/panels/LogPanel.java | 72 ++++++++++++++++++++++-------------- 1 files changed, 44 insertions(+), 28 deletions(-) diff --git a/src/com/gitblit/wicket/panels/LogPanel.java b/src/com/gitblit/wicket/panels/LogPanel.java index 077ebb9..8895dbc 100644 --- a/src/com/gitblit/wicket/panels/LogPanel.java +++ b/src/com/gitblit/wicket/panels/LogPanel.java @@ -4,10 +4,9 @@ import java.util.List; import java.util.Map; -import org.apache.wicket.ajax.markup.html.navigation.paging.AjaxPagingNavigator; import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.image.ContextImage; import org.apache.wicket.markup.html.link.BookmarkablePageLink; -import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.markup.repeater.Item; import org.apache.wicket.markup.repeater.data.DataView; import org.apache.wicket.markup.repeater.data.ListDataProvider; @@ -16,35 +15,47 @@ import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.revwalk.RevCommit; +import com.gitblit.GitBlit; +import com.gitblit.Keys; import com.gitblit.utils.JGitUtils; -import com.gitblit.wicket.GitBlitWebApp; -import com.gitblit.wicket.GitBlitWebSession; +import com.gitblit.utils.JGitUtils.SearchType; +import com.gitblit.utils.StringUtils; import com.gitblit.wicket.LinkPanel; import com.gitblit.wicket.WicketUtils; +import com.gitblit.wicket.pages.CommitDiffPage; import com.gitblit.wicket.pages.CommitPage; -import com.gitblit.wicket.pages.DiffPage; import com.gitblit.wicket.pages.LogPage; +import com.gitblit.wicket.pages.SearchPage; import com.gitblit.wicket.pages.SummaryPage; import com.gitblit.wicket.pages.TreePage; -public class LogPanel extends Panel { +public class LogPanel extends BasePanel { private static final long serialVersionUID = 1L; + + private boolean hasMore = false; - public LogPanel(String wicketId, final String repositoryName, String objectId, Repository r, int limit, int pageOffset) { + public LogPanel(String wicketId, final String repositoryName, final String objectId, Repository r, int limit, int pageOffset) { super(wicketId); - boolean pageResults = limit <= 0; - setOutputMarkupId(pageResults); - + boolean pageResults = limit <= 0; + int itemsPerPage = GitBlit.self().settings().getInteger(Keys.web.logPageCommitCount, 50); + if (itemsPerPage <= 1) { + itemsPerPage = 50; + } + final Map<ObjectId, List<String>> allRefs = JGitUtils.getAllRefs(r); List<RevCommit> commits; if (pageResults) { // Paging result set - commits = JGitUtils.getRevLog(r, objectId, pageOffset*GitBlitWebApp.PAGING_ITEM_COUNT, GitBlitWebApp.PAGING_ITEM_COUNT); + commits = JGitUtils.getRevLog(r, objectId, pageOffset * itemsPerPage, itemsPerPage); } else { // Fixed size result set commits = JGitUtils.getRevLog(r, objectId, 0, limit); } + + // inaccurate way to determine if there are more commits. + // works unless commits.size() represents the exact end. + hasMore = commits.size() >= itemsPerPage; // header if (pageResults) { @@ -66,51 +77,52 @@ final RevCommit entry = item.getModelObject(); final Date date = JGitUtils.getCommitDate(entry); - item.add(WicketUtils.createDateLabel("commitDate", date, GitBlitWebSession.get().getTimezone())); + item.add(WicketUtils.createDateLabel("commitDate", date, getTimeZone())); + // author search link String author = entry.getAuthorIdent().getName(); - item.add(WicketUtils.createAuthorLabel("commitAuthor", author)); + LinkPanel authorLink = new LinkPanel("commitAuthor", "list", author, SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId, author, SearchType.AUTHOR)); + setPersonSearchTooltip(authorLink, author, SearchType.AUTHOR); + item.add(authorLink); + // merge icon + if (entry.getParentCount() > 1) { + item.add(new ContextImage("commitIcon", "/com/gitblit/wicket/resources/commit_merge_16x16.png")); + } else { + item.add(new ContextImage("commitIcon", "/com/gitblit/wicket/resources/blank.png")); + } + + // short message String shortMessage = entry.getShortMessage(); - String trimmedMessage = WicketUtils.trimShortLog(shortMessage); + String trimmedMessage = StringUtils.trimShortLog(shortMessage); LinkPanel shortlog = new LinkPanel("commitShortMessage", "list subject", trimmedMessage, CommitPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName())); if (!shortMessage.equals(trimmedMessage)) { WicketUtils.setHtmlTitle(shortlog, shortMessage); } item.add(shortlog); - item.add(new RefsPanel("commitRefs", entry, allRefs)); + item.add(new RefsPanel("commitRefs", repositoryName, entry, allRefs)); item.add(new BookmarkablePageLink<Void>("view", CommitPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); - item.add(new BookmarkablePageLink<Void>("diff", DiffPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); + item.add(new BookmarkablePageLink<Void>("diff", CommitDiffPage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); item.add(new BookmarkablePageLink<Void>("tree", TreePage.class, WicketUtils.newObjectParameter(repositoryName, entry.getName()))); WicketUtils.setAlternatingBackground(item, counter); counter++; } }; - add(logView); + add(logView); // determine to show pager, more, or neither if (limit <= 0) { // no display limit add(new Label("moreLogs", "").setVisible(false)); - add(new Label("pageLogs", "").setVisible(false)); - } else { + } else { if (pageResults) { // paging add(new Label("moreLogs", "").setVisible(false)); - if (commits.size() == limit) { - // show pager - logView.setItemsPerPage(GitBlitWebApp.PAGING_ITEM_COUNT); - add(new AjaxPagingNavigator("pageLogs", logView)); - } else { - // nothing to page - add(new Label("pageLogs", "").setVisible(false)); - } } else { // more - add(new Label("pageLogs", "").setVisible(false)); if (commits.size() == limit) { // show more add(new LinkPanel("moreLogs", "link", new StringResourceModel("gb.moreLogs", this, null), LogPage.class, WicketUtils.newRepositoryParameter(repositoryName))); @@ -121,4 +133,8 @@ } } } + + public boolean hasMore() { + return hasMore; + } } -- Gitblit v1.9.1