From ed552ba47c02779c270ffd62841d6d1048dade70 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Sun, 22 Nov 2015 14:37:16 -0500 Subject: [PATCH] Merge branch 'develop' --- src/main/java/com/gitblit/wicket/pages/NewTicketPage.java | 38 ++++++++++++++++++++++++++++++++------ 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/gitblit/wicket/pages/NewTicketPage.java b/src/main/java/com/gitblit/wicket/pages/NewTicketPage.java index 21a2af1..0c52505 100644 --- a/src/main/java/com/gitblit/wicket/pages/NewTicketPage.java +++ b/src/main/java/com/gitblit/wicket/pages/NewTicketPage.java @@ -49,8 +49,6 @@ import com.gitblit.tickets.TicketResponsible; import com.gitblit.utils.StringUtils; import com.gitblit.wicket.GitBlitWebSession; -import com.gitblit.wicket.SafeTextModel; -import com.gitblit.wicket.SafeTextModel.Mode; import com.gitblit.wicket.WicketUtils; import com.gitblit.wicket.panels.MarkdownTextArea; @@ -78,6 +76,10 @@ private Label descriptionPreview; + private IModel<TicketModel.Priority> priorityModel; + + private IModel<TicketModel.Severity> severityModel; + public NewTicketPage(PageParameters params) { super(params); @@ -92,11 +94,13 @@ } typeModel = Model.of(TicketModel.Type.defaultType); - titleModel = SafeTextModel.none(); - topicModel = SafeTextModel.none(); + titleModel = Model.of(); + topicModel = Model.of(); mergeToModel = Model.of(Repository.shortenRefName(getRepositoryModel().mergeTo)); responsibleModel = Model.of(); milestoneModel = Model.of(); + severityModel = Model.of(TicketModel.Severity.defaultSeverity); + priorityModel = Model.of(TicketModel.Priority.defaultPriority); setStatelessHint(false); setOutputMarkupId(true); @@ -107,8 +111,9 @@ form.add(new DropDownChoice<TicketModel.Type>("type", typeModel, Arrays.asList(TicketModel.Type.choices()))); form.add(new TextField<String>("title", titleModel)); form.add(new TextField<String>("topic", topicModel)); + form.add(new DropDownChoice<TicketModel.Severity>("severity", severityModel, Arrays.asList(TicketModel.Severity.choices()))); - final SafeTextModel markdownPreviewModel = new SafeTextModel(Mode.none); + final IModel<String> markdownPreviewModel = Model.of(); descriptionPreview = new Label("descriptionPreview", markdownPreviewModel); descriptionPreview.setEscapeModelStrings(false); descriptionPreview.setOutputMarkupId(true); @@ -154,6 +159,11 @@ milestone.add(new DropDownChoice<TicketMilestone>("milestone", milestoneModel, milestones)); form.add(milestone.setVisible(!milestones.isEmpty())); + // priority + Fragment priority = new Fragment("priority", "priorityFragment", this); + priority.add(new DropDownChoice<TicketModel.Priority>("priority", priorityModel, Arrays.asList(TicketModel.Priority.choices()))); + form.add(priority); + // integration branch List<String> branches = new ArrayList<String>(); for (String branch : getRepositoryModel().getLocalBranches()) { @@ -173,6 +183,7 @@ form.add(new Label("responsible").setVisible(false)); form.add(new Label("milestone").setVisible(false)); form.add(new Label("mergeto").setVisible(false)); + form.add(new Label("priority").setVisible(false)); } form.add(new AjaxButton("create") { @@ -214,6 +225,20 @@ change.setField(Field.milestone, milestone.name); } + // severity + TicketModel.Severity severity = TicketModel.Severity.defaultSeverity; + if (severityModel.getObject() != null) { + severity = severityModel.getObject(); + } + change.setField(Field.severity, severity); + + // priority + TicketModel.Priority priority = TicketModel.Priority.defaultPriority; + if (priorityModel.getObject() != null) { + priority = priorityModel.getObject(); + } + change.setField(Field.priority, priority); + // integration branch String mergeTo = mergeToModel.getObject(); if (!StringUtils.isEmpty(mergeTo)) { @@ -224,7 +249,8 @@ if (ticket != null) { TicketNotifier notifier = app().tickets().createNotifier(); notifier.sendMailing(ticket); - setResponsePage(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number)); + + redirectTo(TicketsPage.class, WicketUtils.newObjectParameter(getRepositoryModel().name, "" + ticket.number)); } else { // TODO error } -- Gitblit v1.9.1