From a502d96a860456ec5e8c96761db70f7cabb74751 Mon Sep 17 00:00:00 2001 From: Paul Martin <paul@paulsputer.com> Date: Sat, 30 Apr 2016 04:19:14 -0400 Subject: [PATCH] Merge pull request #1073 from gitblit/1062-DocEditorUpdates --- src/main/java/com/gitblit/git/RepositoryResolver.java | 30 ++++++++++++++---------------- 1 files changed, 14 insertions(+), 16 deletions(-) diff --git a/src/main/java/com/gitblit/git/RepositoryResolver.java b/src/main/java/com/gitblit/git/RepositoryResolver.java index c859f6f..1033637 100644 --- a/src/main/java/com/gitblit/git/RepositoryResolver.java +++ b/src/main/java/com/gitblit/git/RepositoryResolver.java @@ -30,7 +30,8 @@ import com.gitblit.manager.IGitblit; import com.gitblit.models.RepositoryModel; import com.gitblit.models.UserModel; -import com.gitblit.transport.ssh.SshSession; +import com.gitblit.transport.git.GitDaemonClient; +import com.gitblit.transport.ssh.SshDaemonClient; /** * Resolves repositories and grants export access. @@ -68,9 +69,9 @@ // git request GitDaemonClient client = (GitDaemonClient) req; client.setRepositoryName(name); - } else if (req instanceof SshSession) { - SshSession s = (SshSession)req; - s.setRepositoryName(name); + } else if (req instanceof SshDaemonClient) { + SshDaemonClient client = (SshDaemonClient) req; + client.setRepositoryName(name); } return repo; } @@ -82,8 +83,8 @@ protected boolean isExportOk(X req, String repositoryName, Repository db) throws IOException { RepositoryModel model = gitblit.getRepositoryModel(repositoryName); + UserModel user = UserModel.ANONYMOUS; String scheme = null; - UserModel user = null; String origin = null; if (req instanceof GitDaemonClient) { @@ -92,22 +93,19 @@ GitDaemonClient client = (GitDaemonClient) req; scheme = "git"; origin = client.getRemoteAddress().toString(); - user = UserModel.ANONYMOUS; } else if (req instanceof HttpServletRequest) { // http/https request - HttpServletRequest httpRequest = (HttpServletRequest) req; - scheme = httpRequest.getScheme(); - origin = httpRequest.getRemoteAddr(); - user = gitblit.authenticate(httpRequest); + HttpServletRequest client = (HttpServletRequest) req; + scheme = client.getScheme(); + origin = client.getRemoteAddr(); + user = gitblit.authenticate(client); if (user == null) { user = UserModel.ANONYMOUS; } - } else if (req instanceof SshSession) { - SshSession s = (SshSession) req; - user = gitblit.authenticate(s); - if (user == null) { - throw new IOException(String.format("User %s not found", s.getRemoteUser())); - } + } else if (req instanceof SshDaemonClient) { + // ssh is always authenticated + SshDaemonClient client = (SshDaemonClient) req; + user = client.getUser(); } if (user.canClone(model)) { -- Gitblit v1.9.1