From a502d96a860456ec5e8c96761db70f7cabb74751 Mon Sep 17 00:00:00 2001 From: Paul Martin <paul@paulsputer.com> Date: Sat, 30 Apr 2016 04:19:14 -0400 Subject: [PATCH] Merge pull request #1073 from gitblit/1062-DocEditorUpdates --- src/main/java/com/gitblit/utils/MarkdownUtils.java | 22 +++++++++++++++++----- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/gitblit/utils/MarkdownUtils.java b/src/main/java/com/gitblit/utils/MarkdownUtils.java index 2ce6f56..e0c9dd4 100644 --- a/src/main/java/com/gitblit/utils/MarkdownUtils.java +++ b/src/main/java/com/gitblit/utils/MarkdownUtils.java @@ -16,6 +16,7 @@ package com.gitblit.utils; import static org.pegdown.Extensions.ALL; +import static org.pegdown.Extensions.ANCHORLINKS; import static org.pegdown.Extensions.SMARTYPANTS; import java.io.IOException; @@ -25,10 +26,13 @@ import org.apache.commons.io.IOUtils; import org.pegdown.LinkRenderer; +import org.pegdown.ParsingTimeoutException; import org.pegdown.PegDownProcessor; +import org.pegdown.ast.RootNode; import com.gitblit.IStoredSettings; import com.gitblit.Keys; +import com.gitblit.wicket.MarkupProcessor.WorkaroundHtmlSerializer; /** * Utility methods for transforming raw markdown text to html. @@ -72,9 +76,13 @@ * @throws java.text.ParseException */ public static String transformMarkdown(String markdown, LinkRenderer linkRenderer) { - PegDownProcessor pd = new PegDownProcessor(ALL & ~SMARTYPANTS); - String html = pd.markdownToHtml(markdown, linkRenderer == null ? new LinkRenderer() : linkRenderer); - return html; + try { + PegDownProcessor pd = new PegDownProcessor(ALL & ~SMARTYPANTS & ~ANCHORLINKS); + RootNode astRoot = pd.parseMarkdown(markdown.toCharArray()); + return new WorkaroundHtmlSerializer(linkRenderer == null ? new LinkRenderer() : linkRenderer).toHtml(astRoot); + } catch (ParsingTimeoutException e) { + return null; + } } /** @@ -129,13 +137,17 @@ String canonicalUrl = settings.getString(Keys.web.canonicalUrl, "https://localhost:8443"); // emphasize and link mentions - String mentionReplacement = String.format(" **<a href=\"%1s/user/$1\">@$1</a>**", canonicalUrl); + String mentionReplacement = String.format(" **[@$1](%1s/user/$1)**", canonicalUrl); text = text.replaceAll("\\s@([A-Za-z0-9-_]+)", mentionReplacement); + // link ticket refs + String ticketReplacement = MessageFormat.format("$1[#$2]({0}/tickets?r={1}&h=$2)$3", canonicalUrl, repositoryName); + text = text.replaceAll("([\\s,]+)#(\\d+)([\\s,:\\.\\n])", ticketReplacement); + // link commit shas int shaLen = settings.getInteger(Keys.web.shortCommitIdLength, 6); String commitPattern = MessageFormat.format("\\s([A-Fa-f0-9]'{'{0}'}')([A-Fa-f0-9]'{'{1}'}')", shaLen, 40 - shaLen); - String commitReplacement = String.format(" <a class='commit' href='%1$s/commit?r=%2$s&h=$1$2'>$1</a>", canonicalUrl, repositoryName); + String commitReplacement = String.format(" [`$1`](%1$s/commit?r=%2$s&h=$1$2)", canonicalUrl, repositoryName); text = text.replaceAll(commitPattern, commitReplacement); String html = transformMarkdown(text); -- Gitblit v1.9.1