From 2696e12bd643eaca85b9780b1c7d8ec1377df0fb Mon Sep 17 00:00:00 2001
From: latham <latham@ispconfig3>
Date: Fri, 04 Nov 2011 09:57:16 -0400
Subject: [PATCH] This will sort the modules by alpha before the dashboard is pushed to the front.  This patch keeps the menu tabs stable instead of different on each user. Logging in as an admin, reseller, and user would show the tabs in different order each time do to user creation.

---
 interface/lib/classes/db_mysql.inc.php |  221 +++++++++++++++++++++++++++++-------------------------
 1 files changed, 118 insertions(+), 103 deletions(-)

diff --git a/interface/lib/classes/db_mysql.inc.php b/interface/lib/classes/db_mysql.inc.php
index 3266155..fc7b8b3 100644
--- a/interface/lib/classes/db_mysql.inc.php
+++ b/interface/lib/classes/db_mysql.inc.php
@@ -1,14 +1,6 @@
 <?php
-/**
- * mySQL Database class
- * 
- * @author Till Brehm
- * @copyright  2005, Till Brehm, projektfarm Gmbh
- * @version 0.2
- * @package ISPConfig
- */
 /*
-Copyright (c) 2005, Till Brehm, projektfarm Gmbh
+Copyright (c) 2007, Till Brehm, projektfarm Gmbh
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,
@@ -35,20 +27,22 @@
 EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
-class db
-{
-	private $dbHost = '';		// hostname of the MySQL server
-	private $dbName = '';		// logical database name on that server
-	private $dbUser = '';		// database authorized user
-	private $dbPass = '';		// user's password
-	private $linkId = 0;		// last result of mysql_connect()
-	private $queryId = 0;		// last result of mysql_query()
-	private $record	= array();	// last record fetched
-    private $autoCommit = 1;    // Autocommit Transactions
-	private $currentRow;		// current row number
-	private $errorNumber = 0;	// last error number
-	public $errorMessage = '';	// last error message
-	private $errorLocation = '';// last error location
+class db {
+	private $dbHost = '';		   // hostname of the MySQL server
+	private $dbName = '';		   // logical database name on that server
+	private $dbUser = '';		   // database authorized user
+	private $dbPass = '';		   // user's password
+	private $dbCharset = '';	   // what charset comes and goes to mysql: utf8 / latin1
+	private $dbNewLink = false;    // Return a new linkID when connect is called again
+	private $dbClientFlags = 0;    // MySQL Client falgs
+	private $linkId = 0;		   // last result of mysql_connect()
+	private $queryId = 0;		   // last result of mysql_query()
+	private $record	= array();	   // last record fetched
+	private $autoCommit = 1;	    // Autocommit Transactions
+	private $currentRow;		   // current row number
+	private $errorNumber = 0;	   // last error number
+	public $errorMessage = '';	   // last error message
+	private $errorLocation = '';   // last error location
 	public $show_error_messages = false;
 
 	public function __construct()
@@ -58,6 +52,9 @@
 		$this->dbName = $conf['db_database'];
 		$this->dbUser = $conf['db_user'];
 		$this->dbPass = $conf['db_password'];
+		$this->dbCharset = $conf['db_charset'];
+		$this->dbNewLink = $conf['db_new_link'];
+		$this->dbClientFlags = $conf['db_client_flags'];
 		//$this->connect();
 	}
 
@@ -74,19 +71,21 @@
 	}
 
 	public function connect()
-    {
+	{
 		if($this->linkId == 0){
-			$this->linkId = mysql_connect($this->dbHost, $this->dbUser, $this->dbPass);
+			$this->linkId = mysql_connect($this->dbHost, $this->dbUser, $this->dbPass, $this->dbNewLink, $this->dbClientFlags);
 			if(!$this->linkId){
 				$this->updateError('DB::connect()<br />mysql_connect');
 				return false;
 			}
+    		$this->queryId = @mysql_query('SET NAMES '.$this->dbCharset, $this->linkId);
+			$this->queryId = @mysql_query("SET character_set_results = '".$this->dbCharset."', character_set_client = '".$this->dbCharset."', character_set_connection = '".$this->dbCharset."', character_set_database = '".$this->dbCharset."', character_set_server = '".$this->dbCharset."'", $this->linkId);
 		}
 		return true;
 	}
 
 	public function query($queryString)
-    {
+	{
 		if(!$this->connect()){
 			return false;
 		}
@@ -105,7 +104,7 @@
 
 	/** Returns all records as an array */
 	public function queryAllRecords($queryString)
-    {
+	{
 		if(!$this->query($queryString)){
 			return false;
 		}
@@ -118,7 +117,7 @@
 
 	/** Returns one row as an array */
 	public function queryOneRecord($queryString)
-    {
+	{
 		if(!$this->query($queryString) || $this->numRows() == 0){
 			return false;
 		}
@@ -127,8 +126,8 @@
 
 	/** Returns the next record as an array */
 	public function nextRecord()
-    {
-        $this->record = mysql_fetch_assoc($this->queryId);
+	{
+	$this->record = mysql_fetch_assoc($this->queryId);
 		$this->updateError('DB::nextRecord()<br />mysql_fetch_array');
 		if(!$this->record || !is_array($this->record)){
 			return false;
@@ -150,7 +149,7 @@
 		
 	/** Returns the last mySQL insert_id() */
 	public function insertID()
-    {
+	{
 		return mysql_insert_id($this->linkId);
 	}
         
@@ -160,10 +159,14 @@
         return $this->quote($formfield);
     }
 		
-	/** Escapes quotes in variable. addslashes() */
+	/** Escapes quotes in variable. mysql_real_escape_string() */
     public function quote($formfield)
-    {
-        return addslashes($formfield);
+    {	
+		if(!$this->connect()){
+			$this->updateError('WARNING: mysql_connect: Used addslashes instead of mysql_real_escape_string');
+			return addslashes($formfield);
+		}
+        return mysql_real_escape_string($formfield, $this->linkId);
     }
 		
 	/** Unquotes a variable, strip_slashes() */
@@ -217,6 +220,41 @@
         }
     }
 	*/
+
+	public function diffrec($record_old, $record_new) {
+		$diffrec_full = array();
+		$diff_num = 0;
+
+		if(is_array($record_old) && count($record_old) > 0) {
+			foreach($record_old as $key => $val) {
+				// if(!isset($record_new[$key]) || $record_new[$key] != $val) {
+				if($record_new[$key] != $val) {
+					// Record has changed
+					$diffrec_full['old'][$key] = $val;
+					$diffrec_full['new'][$key] = $record_new[$key];
+					$diff_num++;
+				} else {
+					$diffrec_full['old'][$key] = $val;
+					$diffrec_full['new'][$key] = $val;
+				}
+			}
+		} elseif(is_array($record_new)) {
+			foreach($record_new as $key => $val) {
+				if(isset($record_new[$key]) && @$record_old[$key] != $val) {
+					// Record has changed
+					$diffrec_full['new'][$key] = $val;
+					$diffrec_full['old'][$key] = @$record_old[$key];
+					$diff_num++;
+				} else {
+					$diffrec_full['new'][$key] = $val;
+					$diffrec_full['old'][$key] = $val;
+				}
+			}
+		}
+		
+		return array('diff_num' => $diff_num, 'diff_rec' => $diffrec_full);
+		
+	}
 	
 	//** Function to fill the datalog with a full differential record.
 	public function datalogSave($db_table, $action, $primary_field, $primary_id, $record_old, $record_new) {
@@ -229,44 +267,22 @@
 			$escape = '`';
 		}
 
-		$diffrec_full = array();
-		$diff_num = 0;
-
-		if(is_array($record_old) && count($record_old) > 0) {
-			foreach($record_old as $key => $val) {
-				if(!isset($record_new[$key]) || $record_new[$key] != $val) {
-					// Record has changed
-					$diffrec_full['old'][$key] = $val;
-					$diffrec_full['new'][$key] = $record_new[$key];
-					$diff_num++;
-				} else {
-					$diffrec_full['old'][$key] = $val;
-					$diffrec_full['new'][$key] = $val;
-				}
-			}
-		} elseif(is_array($record_new)) {
-			foreach($record_new as $key => $val) {
-				if(isset($record_new[$key]) && $record_old[$key] != $val) {
-					// Record has changed
-					$diffrec_full['new'][$key] = $val;
-					$diffrec_full['old'][$key] = $record_old[$key];
-					$diff_num++;
-				} else {
-					$diffrec_full['new'][$key] = $val;
-					$diffrec_full['old'][$key] = $val;
-				}
-			}
-		}
+		$tmp = $this->diffrec($record_old, $record_new);
+		$diffrec_full = $tmp['diff_rec'];
+		$diff_num = $tmp['diff_num'];
+		unset($tmp);
 		
 		// Insert the server_id, if the record has a server_id
-		$server_id = (isset($record_old["server_id"]) && $record_old["server_id"] > 0)?$record_old["server_id"]:0;
-		if(isset($record_new["server_id"])) $server_id = $record_new["server_id"];
+		$server_id = (isset($record_old['server_id']) && $record_old['server_id'] > 0)?$record_old['server_id']:0;
+		if(isset($record_new['server_id'])) $server_id = $record_new['server_id'];
 		
 
 		if($diff_num > 0) {
+			//print_r($diff_num);
+			//print_r($diffrec_full);
 			$diffstr = $app->db->quote(serialize($diffrec_full));
-			$username = $app->db->quote($_SESSION["s"]["user"]["username"]);
-			$dbidx = $primary_field.":".$primary_id;
+			$username = $app->db->quote($_SESSION['s']['user']['username']);
+			$dbidx = $primary_field.':'.$primary_id;
 						
 			if($action == 'INSERT') $action = 'i';
 			if($action == 'UPDATE') $action = 'u';
@@ -278,7 +294,7 @@
 		return true;
 	}
 	
-	//** Updates a record and saves the changes into the datalog
+	//** Inserts a record and saves the changes into the datalog
 	public function datalogInsert($tablename, $insert_data, $index_field) {
 		global $app;
 		
@@ -288,7 +304,7 @@
 		$new_rec = $this->queryOneRecord("SELECT * FROM $tablename WHERE $index_field = '$index_value'");
 		$this->datalogSave($tablename, 'INSERT', $index_field, $index_value, $old_rec, $new_rec);
 		
-		return true;
+		return $index_value;
 	}
 	
 	//** Updates a record and saves the changes into the datalog
@@ -314,8 +330,8 @@
 		
 		return true;
 	}
-	
-	
+
+
        
     public function closeConn()
     {
@@ -325,7 +341,7 @@
     		return true;
     	} else { return false; }
     }
-       
+    
     public function freeResult($query) 
     {
     	if(mysql_free_result($query))
@@ -393,10 +409,10 @@
             if(isset($col['option']) && $col['option'] == 'primary'){ $index .= 'PRIMARY KEY ('.$col['name'].'),'; }
             if(isset($col['option']) && $col['option'] == 'index'){   $index .= 'INDEX ('.$col['name'].'),'; }
             if(isset($col['option']) && $col['option'] == 'unique'){  $index .= 'UNIQUE ('.$col['name'].'),'; }
-        }
+       }
        $sql .= $index;
        $sql = substr($sql,0,-1);
-       $sql .= ')';  
+       $sql .= ')';
        $this->query($sql);
        return true;
     }
@@ -415,36 +431,36 @@
     */
     public function alterTable($table_name,$columns)
     {
-        $index = '';
-        $sql = "ALTER TABLE $table_name ";
-        foreach($columns as $col){
+       $index = '';
+       $sql = "ALTER TABLE $table_name ";
+       foreach($columns as $col){
             if($col['action'] == 'add'){
-                $sql .= 'ADD '.$col['name'].' '.$this->mapType($col['type'], $col['typeValue']).' ';
+                $sql .= 'ADD '.$col['name'].' '.$this->mapType($col['type'],$col['typeValue']).' ';
             }elseif($col['action'] == 'alter') {
                 $sql .= 'CHANGE '.$col['name'].' '.$col['name_new'].' '.$this->mapType($col['type'],$col['typeValue']).' ';
             }elseif($col['action'] == 'drop') {
                 $sql .= 'DROP '.$col['name'].' ';
             }
-            if($col["action"] != 'drop') {  
-            if($col["defaultValue"] != "") $sql .= "DEFAULT '".$col["defaultValue"]."' ";
-            if($col["notNull"] == true) {
-                $sql .= "NOT NULL ";
+            if($col['action'] != 'drop') {  
+            if($col['defaultValue'] != '') $sql .= "DEFAULT '".$col['defaultValue']."' ";
+            if($col['notNull'] == true) {
+                $sql .= 'NOT NULL ';
             } else {
-                $sql .= "NULL ";
+                $sql .= 'NULL ';
             }
-            if($col["autoInc"] == true) $sql .= "auto_increment ";
-            $sql.= ",";
+            if($col['autoInc'] == true) $sql .= 'auto_increment ';
+            $sql.= ',';
             //* Index definitions
             if($col['option'] == 'primary') $index .= 'PRIMARY KEY ('.$col['name'].'),';
             if($col['option'] == 'index') $index .= 'INDEX ('.$col['name'].'),';
             if($col['option'] == 'unique') $index .= 'UNIQUE ('.$col['name'].'),';
             }
-        }
-        $sql .= $index;
-        $sql = substr($sql,0,-1);
-        //die($sql);
-        $this->query($sql);
-        return true;
+       }
+       $sql .= $index;
+       $sql = substr($sql,0,-1);
+       //die($sql);
+       $this->query($sql);
+       return true;
     }
        
     public function dropTable($table_name) 
@@ -470,16 +486,15 @@
        
        
     public function tableInfo($table_name) {
-        global $go_api,$go_info;
         //* Tabellenfelder einlesen ?
-        if($rows = $go_api->db->queryAllRecords("SHOW FIELDS FROM $table_name")){
+        if($rows = $this->queryAllRecords('SHOW FIELDS FROM '.$table_name)){
         foreach($rows as $row) {
-            $name    = $row[0];
-            $default = $row[4];
-            $key     = $row[3];
-            $extra   = $row[5];
-            $isnull  = $row[2];
-            $type    = $row[1];
+            $name    = $row['Field'];
+            $default = $row['Default'];
+            $key     = $row['Key'];
+            $extra   = $row['Extra'];
+            $isnull  = $row['Null'];
+            $type    = $row['Type'];
         
             $column = array('name' => $name, 'defaultValue' => $default);
             //$column["type"] = $type;
@@ -500,9 +515,9 @@
                 $tmp_typeValue = explode('(',$type);
                 $column['typeValue'] = substr($tmp_typeValue[1], 0, -1);  
             }
-            if(stristr($type, 'text'))   $metaType = 'text';
-            if(stristr($type, 'double')) $metaType = 'double';
-            if(stristr($type, 'blob'))   $metaType = 'blob';
+            if(stristr($type,'text'))   $metaType = 'text';
+            if(stristr($type,'double')) $metaType = 'double';
+            if(stristr($type,'blob'))   $metaType = 'blob';
             
             $column['type'] = $metaType;
             $columns[] = $column;
@@ -536,7 +551,7 @@
             return 'blob';
         }
     }
-	
+
 }
 
-?>
\ No newline at end of file
+?>

--
Gitblit v1.9.1