From 37b29231e47a0c4458dc1c15d98588f16f07e1e2 Mon Sep 17 00:00:00 2001
From: Marius Cramer <m.cramer@pixcept.de>
Date: Thu, 06 Aug 2015 03:18:44 -0400
Subject: [PATCH] - don't set password via remoting if field is empty
---
interface/web/mail/mail_transport_edit.php | 106 ++++++++++++++++++++++++++++++++--------------------
1 files changed, 65 insertions(+), 41 deletions(-)
diff --git a/interface/web/mail/mail_transport_edit.php b/interface/web/mail/mail_transport_edit.php
index 9b6c4e3..9707d2f 100644
--- a/interface/web/mail/mail_transport_edit.php
+++ b/interface/web/mail/mail_transport_edit.php
@@ -38,8 +38,8 @@
* End Form configuration
******************************************/
-require_once('../../lib/config.inc.php');
-require_once('../../lib/app.inc.php');
+require_once '../../lib/config.inc.php';
+require_once '../../lib/app.inc.php';
//* Check permissions for module
$app->auth->check_module_permissions('mail');
@@ -50,52 +50,54 @@
$app->load('tform_actions');
class page_action extends tform_actions {
-
+
function onShowNew() {
global $app, $conf;
-
+
// we will check only users, not admins
if($_SESSION["s"]["user"]["typ"] == 'user') {
-
- // Get the limits of the client
- $client_group_id = $_SESSION["s"]["user"]["default_group"];
- $client = $app->db->queryOneRecord("SELECT limit_mailrouting FROM sys_group, client WHERE sys_group.client_id = client.client_id and sys_group.groupid = $client_group_id");
-
- // Check if the user may add another transport.
- if($client["limit_mailrouting"] >= 0) {
- $tmp = $app->db->queryOneRecord("SELECT count(transport_id) as number FROM mail_transport WHERE sys_groupid = $client_group_id");
- if($tmp["number"] >= $client["limit_mailrouting"]) {
- $app->error($app->tform->wordbook["limit_mailrouting_txt"]);
- }
+ if(!$app->tform->checkClientLimit('limit_mailrouting')) {
+ $app->error($app->tform->wordbook["limit_mailrouting_txt"]);
+ }
+ if(!$app->tform->checkResellerLimit('limit_mailrouting')) {
+ $app->error('Reseller: '.$app->tform->wordbook["limit_mailrouting_txt"]);
}
}
-
+
parent::onShowNew();
}
-
+
function onShowEnd() {
global $app, $conf;
-
- $tmp_parts = explode(":",$this->dataRecord["transport"]);
- if(empty($this->id) && empty($tmp_parts[0])) {
- $rec["type"] = 'smtp';
+
+ $types = array('smtp' => 'smtp', 'uucp' => 'uucp', 'slow' => 'slow', 'error' => 'error', 'custom' => 'custom', '' => 'null');
+ $tmp_parts = explode(":", $this->dataRecord["transport"]);
+ if(!empty($this->id) && !stristr($this->dataRecord["transport"], ':')) {
+ $rec["type"] = 'custom';
} else {
- $rec["type"] = $tmp_parts[0];
+ if(empty($this->id) && empty($tmp_parts[0])) {
+ $rec["type"] = 'smtp';
+ } else {
+ $rec["type"] = $types[$tmp_parts[0]] ? $tmp_parts[0] : 'custom';
+ }
}
- if(@$tmp_parts[2] != '') {
+ if($rec["type"] == 'custom') {
+ $dest = $this->dataRecord["transport"];
+ } elseif(!empty($tmp_parts[2])) {
$dest = @$tmp_parts[1].':'.@$tmp_parts[2];
- } else {
+ } elseif(!empty($tmp_parts[1]) || $this->dataRecord["transport"] == ":") {
$dest = $tmp_parts[1];
+ } else {
+ $dest = $this->dataRecord["transport"];
}
- if(@substr($dest,0,1) == '[') {
+ if(@substr($dest, 0, 1) == '[') {
$rec["mx"] = 'checked="CHECKED"';
- $rec["destination"] = @str_replace(']','',@str_replace('[','',$dest));
+ $rec["destination"] = @str_replace(']', '', @str_replace('[', '', $dest));
} else {
$rec["mx"] = '';
$rec["destination"] = @$dest;
}
-
- $types = array('smtp' => 'smtp','uucp' => 'uucp','slow' => 'slow', 'error' => 'error', '' => 'null');
+
$type_select = '';
if(is_array($types)) {
foreach( $types as $key => $val) {
@@ -107,33 +109,49 @@
$app->tpl->setVar($rec);
unset($type);
unset($types);
-
+
parent::onShowEnd();
}
-
+
+ function onBeforeUpdate() {
+ global $app, $conf;
+
+ //* Check if the server has been changed
+ // We do this only for the admin or reseller users, as normal clients can not change the server ID anyway
+ if($_SESSION["s"]["user"]["typ"] == 'admin' || $app->auth->has_clients($_SESSION['s']['user']['userid'])) {
+ $rec = $app->db->queryOneRecord("SELECT server_id from mail_transport WHERE transport_id = ".$this->id);
+ if($rec['server_id'] != $this->dataRecord["server_id"]) {
+ //* Add a error message and switch back to old server
+ $app->tform->errorMessage .= $app->lng('The Server can not be changed.');
+ $this->dataRecord["server_id"] = $rec['server_id'];
+ }
+ unset($rec);
+ }
+ }
+
function onSubmit() {
global $app, $conf;
-
+
// Check the client limits, if user is not the admin
if($_SESSION["s"]["user"]["typ"] != 'admin') { // if user is not admin
// Get the limits of the client
- $client_group_id = $_SESSION["s"]["user"]["default_group"];
- $client = $app->db->queryOneRecord("SELECT limit_mailrouting FROM sys_group, client WHERE sys_group.client_id = client.client_id and sys_group.groupid = $client_group_id");
+ $client_group_id = $app->functions->intval($_SESSION["s"]["user"]["default_group"]);
+ $client = $app->db->queryOneRecord("SELECT limit_mailrouting FROM sys_group, client WHERE sys_group.client_id = client.client_id and sys_group.groupid = ?", $client_group_id);
// Check if the user may add another transport.
if($this->id == 0 && $client["limit_mailrouting"] >= 0) {
- $tmp = $app->db->queryOneRecord("SELECT count(transport_id) as number FROM mail_transport WHERE sys_groupid = $client_group_id");
+ $tmp = $app->db->queryOneRecord("SELECT count(transport_id) as number FROM mail_transport WHERE sys_groupid = ?", $client_group_id);
if($tmp["number"] >= $client["limit_mailrouting"]) {
$app->tform->errorMessage .= $app->tform->wordbook["limit_mailrouting_txt"]."<br>";
}
unset($tmp);
}
} // end if user is not admin
-
+
//* Compose transport field
if($this->dataRecord["mx"] == 'y') {
- if(stristr($this->dataRecord["destination"],':')) {
- $tmp_parts = explode(":",$this->dataRecord["destination"]);
+ if(stristr($this->dataRecord["destination"], ':')) {
+ $tmp_parts = explode(":", $this->dataRecord["destination"]);
$transport = '['.$tmp_parts[0].']:'.$tmp_parts[1];
} else {
$transport = '['.$this->dataRecord["destination"].']';
@@ -141,17 +159,23 @@
} else {
$transport = $this->dataRecord["destination"];
}
- $this->dataRecord["transport"] = $this->dataRecord["type"].':'.$transport;
+
+ if($this->dataRecord["type"] == 'custom') {
+ $this->dataRecord["transport"] = $transport;
+ } else {
+ $this->dataRecord["transport"] = $this->dataRecord["type"].':'.$transport;
+ }
+
unset($this->dataRecord["type"]);
unset($this->dataRecord["mx"]);
unset($this->dataRecord["destination"]);
-
+
parent::onSubmit();
}
-
+
}
$page = new page_action;
$page->onLoad();
-?>
\ No newline at end of file
+?>
--
Gitblit v1.9.1