From 40c436b6e2724e98efb51582d1ad8fad6dcf4a1c Mon Sep 17 00:00:00 2001 From: tbrehm <t.brehm@ispconfig.org> Date: Fri, 09 Sep 2011 08:28:25 -0400 Subject: [PATCH] - Implemented: FS#1339 - Add "disablesieve" to mail_user table - Added fields for IPv6 support and virtualhost Port Configuration to server_ip table --- server/plugins-available/cron_plugin.inc.php | 33 ++++++++++++++++++++++++++------- 1 files changed, 26 insertions(+), 7 deletions(-) diff --git a/server/plugins-available/cron_plugin.inc.php b/server/plugins-available/cron_plugin.inc.php index 923d8b5..9b6099d 100644 --- a/server/plugins-available/cron_plugin.inc.php +++ b/server/plugins-available/cron_plugin.inc.php @@ -97,7 +97,7 @@ $app->log("Parent domain not found",LOGLEVEL_WARN); return 0; } elseif($parent_domain["system_user"] == 'root' or $parent_domain["system_group"] == 'root') { - $app->log("Websites (and Crons) can not be owned by the root user or group.",LOGLEVEL_WARN); + $app->log("Websites (and Crons) cannot be owned by the root user or group.",LOGLEVEL_WARN); return 0; } @@ -133,14 +133,23 @@ exec("setquota -T -u $username 604800 604800 -a &> /dev/null"); } - // make temp direcory writable for the apache user and the website user - exec("chmod 777 ".escapeshellcmd($parent_domain["document_root"]."/tmp")); + //TODO : change this when distribution information has been integrated into server record + //* Gentoo requires a user to be part of the crontab group. + if (file_exists('/etc/gentoo-release')) { + if (strpos($app->system->get_user_groups($username), 'crontab') === false) { + $app->system->add_user_to_group('crontab', $username); + } + } + + // make temp directory writable for the apache and website users + chmod(escapeshellcmd($parent_domain["document_root"].'/tmp'), 0777); /** TODO READ CRON MASTER **/ $this->parent_domain = $parent_domain; $this->_write_crontab(); + $this->action = ''; } @@ -185,8 +194,12 @@ $cron_jobs = $app->db->queryAllRecords("SELECT `run_min`, `run_hour`, `run_mday`, `run_month`, `run_wday`, `command`, `type` FROM `cron` WHERE `parent_domain_id` = ".intval($this->parent_domain["domain_id"]) . " AND `active` = 'y'"); if($cron_jobs && count($cron_jobs) > 0) { foreach($cron_jobs as $job) { - $command = "{$job['run_min']}\t{$job['run_hour']}\t{$job['run_mday']}\t{$job['run_month']}\t{$job['run_wday']}"; - $command .= "\t{$this->parent_domain['system_user']}"; //* running as user + if($job['run_month'] == '@reboot') { + $command = "@reboot"; + } else { + $command = "{$job['run_min']}\t{$job['run_hour']}\t{$job['run_mday']}\t{$job['run_month']}\t{$job['run_wday']}"; + } + $command .= "\t{$this->parent_domain['system_user']}"; //* running as user if($job['type'] == 'url') { $command .= "\t{$cron_config['wget']} -q -O /dev/null " . escapeshellarg($job['command']) . " >/dev/null 2>&1"; } else { @@ -198,7 +211,7 @@ } $command .= "\t"; - if(substr($job['command'], 0, 1) != "/") $command .= $this->parent_domain['document_root']; + if(substr($job['command'], 0, 1) != "/") $command .= $this->parent_domain['document_root'].'/'; $command .= $job['command']; } @@ -213,6 +226,12 @@ } $cron_file = escapeshellcmd($cron_config["crontab_dir"].'/ispc_'.$this->parent_domain["system_user"]); + //TODO : change this when distribution information has been integrated into server record + //* Gentoo vixie-cron requires files to end with .cron in the cron.d directory + if (file_exists('/etc/gentoo-release')) { + $cron_file .= '.cron'; + } + if($cmd_count > 0) { file_put_contents($cron_file, $cron_content); $app->log("Wrote Cron file $cron_file with content:\n$cron_content",LOGLEVEL_DEBUG); @@ -235,4 +254,4 @@ } // end class -?> \ No newline at end of file +?> -- Gitblit v1.9.1