From 47cca9bb2f0736cff62ae5af39aff0d88f20eca1 Mon Sep 17 00:00:00 2001 From: tbrehm <t.brehm@ispconfig.org> Date: Wed, 10 Jun 2009 10:56:05 -0400 Subject: [PATCH] Fixed: FS#767 - Make sure ServerAlias directive never exceeds 8192 bytes --- server/plugins-available/apache2_plugin.inc.php | 32 +++++++++++++++++++++++++------- 1 files changed, 25 insertions(+), 7 deletions(-) diff --git a/server/plugins-available/apache2_plugin.inc.php b/server/plugins-available/apache2_plugin.inc.php index 87ed509..18e0a75 100644 --- a/server/plugins-available/apache2_plugin.inc.php +++ b/server/plugins-available/apache2_plugin.inc.php @@ -527,25 +527,26 @@ // get alias domains (co-domains and subdomains) $aliases = $app->db->queryAllRecords("SELECT * FROM web_domain WHERE parent_domain_id = ".$data["new"]["domain_id"]." AND active = 'y'"); - switch($data["new"]["subdomain"]) { + $server_alias = array(); + switch($data["new"]["subdomain"]) { case 'www': - $server_alias .= 'www.'.$data["new"]["domain"].' '; + $server_alias[] .= 'www.'.$data["new"]["domain"].' '; break; case '*': - $server_alias .= '*.'.$data["new"]["domain"].' '; + $server_alias[] .= '*.'.$data["new"]["domain"].' '; break; } if(is_array($aliases)) { foreach($aliases as $alias) { switch($alias["subdomain"]) { case 'www': - $server_alias .= 'www.'.$alias["domain"].' '.$alias["domain"].' '; + $server_alias[] .= 'www.'.$alias["domain"].' '.$alias["domain"].' '; break; case '*': - $server_alias .= '*.'.$alias["domain"].' '.$alias["domain"].' '; + $server_alias[] .= '*.'.$alias["domain"].' '.$alias["domain"].' '; break; default: - $server_alias .= $alias["domain"].' '; + $server_alias[] .= $alias["domain"].' '; break; } $app->log("Add server alias: $alias[domain]",LOGLEVEL_DEBUG); @@ -570,7 +571,24 @@ } } } - $tpl->setVar('alias',trim($server_alias)); + + //* If we have some alias records + if(count($server_alias) > 0) { + $server_alias_str = ''; + $n = 0; + + // begin a new ServerAlias line after 30 alias domains + foreach($server_alias as $tmp_alias) { + if($n % 30 == 0) $server_alias_str .= "\n ServerAlias "; + $server_alias_str .= $tmp_alias; + } + unset($tmp_alias); + + $tpl->setVar('alias',trim($server_alias_str)); + } else { + $tpl->setVar('alias',''); + } + if(count($rewrite_rules) > 0) { $tpl->setVar('rewrite_enabled',1); } else { -- Gitblit v1.9.1