From 5ca959fa688255a8de61f89fe2751eb4d24a6912 Mon Sep 17 00:00:00 2001
From: Florian Schaal <florian@schaal-24.de>
Date: Tue, 22 Mar 2016 09:22:07 -0400
Subject: [PATCH] fixed typo

---
 server/lib/classes/cron.d/500-backup_mail.inc.php |  172 +++++++++++++++++++++++++++++++++++++++++----------------
 1 files changed, 124 insertions(+), 48 deletions(-)

diff --git a/server/lib/classes/cron.d/500-backup_mail.inc.php b/server/lib/classes/cron.d/500-backup_mail.inc.php
index f95f815..04a4249 100644
--- a/server/lib/classes/cron.d/500-backup_mail.inc.php
+++ b/server/lib/classes/cron.d/500-backup_mail.inc.php
@@ -27,10 +27,11 @@
 EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
-class cronjob_backup extends cronjob {
+class cronjob_backup_mail extends cronjob {
 
 	// job schedule
 	protected $_schedule = '0 0 * * *';
+	private $tmp_backup_dir = '';
 
 	/* this function is optional if it contains no custom code */
 	public function onPrepare() {
@@ -51,28 +52,20 @@
 
 		$server_config = $app->getconf->get_server_config($conf['server_id'], 'server');
 		$mail_config = $app->getconf->get_server_config($conf['server_id'], 'mail');
-
-		$backup_dir = $server_config['backup_dir'];
+		$global_config = $app->getconf->get_global_config('sites');
+		
+		$backup_dir = trim($server_config['backup_dir']);
 		$backup_dir_permissions =0750;
 
 		$backup_mode = $server_config['backup_mode'];
 		if($backup_mode == '') $backup_mode = 'userzip';
 
 		if($backup_dir != '') {
-			//* mount backup directory, if necessary
 			$run_backups = true;
-			$server_config['backup_dir_mount_cmd'] = trim($server_config['backup_dir_mount_cmd']);
-			if($server_config['backup_dir_is_mount'] == 'y' && $server_config['backup_dir_mount_cmd'] != ''){
-				if(!$app->system->is_mounted($backup_dir)){
-					exec(escapeshellcmd($server_config['backup_dir_mount_cmd']));
-					sleep(1);
-					if(!$app->system->is_mounted($backup_dir)) $run_backups = false;
-				}
-			}
+			//* mount backup directory, if necessary
+			if( $server_config['backup_dir_is_mount'] == 'y' && !$app->system->mount_backup_dir($backup_dir) ) $run_backups = false;
 
-			$sql = "SELECT * FROM mail_user WHERE server_id = '".intval($conf['server_id'])."' AND maildir <> ''";
-			$records = $app->db->queryAllRecords($sql);
-
+			$records = $app->db->queryAllRecords("SELECT * FROM mail_user WHERE server_id = ? AND maildir != ''", intval($conf['server_id']));
 			if(is_array($records) && $run_backups) {
 				if(!is_dir($backup_dir)) {
 					mkdir(escapeshellcmd($backup_dir), $backup_dir_permissions, true);
@@ -82,42 +75,100 @@
 
 				foreach($records as $rec) {
 					//* Do the mailbox backup
+					$email = $rec['email'];
+					$temp = explode("@",$email);
+					$domain = $temp[1];
+					unset($temp);
+					$domain_rec=$app->db->queryOneRecord("SELECT * FROM mail_domain WHERE domain = ?", $domain);
+
 					if($rec['backup_interval'] == 'daily' or ($rec['backup_interval'] == 'weekly' && date('w') == 0) or ($rec['backup_interval'] == 'monthly' && date('d') == '01')) {
-						$sql = "SELECT * FROM mail_domain WHERE domain = '".$app->db->quote(explode("@",$rec['email'])[1])."'";
-						$domain_rec=$app->db->queryOneRecord($sql);
+						
+						$backupusername = 'root';
+						$backupgroup = 'root';
+						if ($global_config['backups_include_into_web_quota'] == 'y') {
+							// this only works, if mail and webdomains are on the same server
+							// find webdomain fitting to maildomain
+							$sql = "SELECT * FROM web_domain WHERE domain = ?";
+							$webdomain = $app->db->queryOneRecord($sql, $domain_rec['domain']);
+							// if this is not also the website, find website now
+							if ($webdomain && ($webdomain['parent_domain_id'] != 0)) {
+								do {
+									$sql = "SELECT * FROM web_domain WHERE domain_id = ?";
+									$webdomain = $app->db->queryOneRecord($sql, $webdomain['parent_domain_id']);
+								} while ($webdomain && ($webdomain['parent_domain_id'] != 0));
+							}
+							// if webdomain is found, change username/group now
+							if ($webdomain) {
+								$backupusername = $webdomain['system_user'];
+								$backupgroup = $webdomain['system_group'];
+							}
+						}						
 
 						$mail_backup_dir = $backup_dir.'/mail'.$domain_rec['domain_id'];
 						if(!is_dir($mail_backup_dir)) mkdir($mail_backup_dir, 0750);
 						chmod($mail_backup_dir, $backup_dir_permissions);
+						chown($mail_backup_dir, $backupusername);
+						chgrp($mail_backup_dir, $backupgroup);
 
 						$mail_backup_file = 'mail'.$rec['mailuser_id'].'_'.date('Y-m-d_H-i');
 
-						$domain_dir=explode('/',$rec['maildir']); 
-						$_temp=array_pop($domain_dir);unset($_temp);
-						$domain_dir=implode('/',$domain_dir);
-
-						$source_dir=array_pop(explode('/',$rec['maildir']));
-
-						//* create archives
-						if($backup_mode == 'userzip') {
-							$mail_backup_file.='.zip';
-							exec('cd '.$rec['homedir'].' && zip -b /tmp -r '.$mail_backup_dir.'/'.$mail_backup_file.' '.$source_dir.' > /dev/nul');
-						} else {
-							/* Create a tar.gz backup */
-							$mail_backup_file.='.tar.gz';
-							exec(escapeshellcmd('tar pczf '.$mail_backup_dir.'/'.$mail_backup_file.' --directory '.$domain_dir.' '.$source_dir), $tmp_output, $retval);
+						// in case of mdbox -> create backup with doveadm before zipping
+						if ($rec['maildir_format'] == 'mdbox') {
+							if (empty($this->tmp_backup_dir)) $this->tmp_backup_dir = $rec['maildir'];
+							// Create temporary backup-mailbox
+							exec("su -c 'dsync backup -u \"".$rec["email"]."\" mdbox:".$this->tmp_backup_dir."/backup'", $tmp_output, $retval);
+		
+							if($backup_mode == 'userzip') {
+								$mail_backup_file.='.zip';
+								exec('cd '.$this->tmp_backup_dir.' && zip '.$mail_backup_dir.'/'.$mail_backup_file.' -b /tmp -r backup > /dev/null && rm -rf backup', $tmp_output, $retval);
+							}
+							else {
+								$mail_backup_file.='.tar.gz';
+								exec(escapeshellcmd('tar pczf '.$mail_backup_dir.'/'.$mail_backup_file.' --directory '.$this->tmp_backup_dir.' backup && rm -rf '.$this->tmp_backup_dir.'/backup'), $tmp_output, $retval);
+							}
+							
+							if ($retval != 0) {
+								// Cleanup
+								if (file_exists($this->tmp_backup_dir.'/backup')) exec('rm -rf '.$this->tmp_backup_dir.'/backup');
+							}
 						}
+						else {
+							$domain_dir=explode('/',$rec['maildir']);
+							$_temp=array_pop($domain_dir);unset($_temp);
+							$domain_dir=implode('/',$domain_dir);
+							
+							$parts=explode('/',$rec['maildir']);
+							$source_dir=array_pop($parts);
+							unset($parts);
+							
+							//* create archives
+							if($backup_mode == 'userzip') {
+								$mail_backup_file.='.zip';
+								exec('cd '.$domain_dir.' && zip '.$mail_backup_dir.'/'.$mail_backup_file.' -b /tmp -r '.$source_dir.' > /dev/null', $tmp_output, $retval);
+							} else {
+								/* Create a tar.gz backup */
+								$mail_backup_file.='.tar.gz';
+								exec(escapeshellcmd('tar pczf '.$mail_backup_dir.'/'.$mail_backup_file.' --directory '.$domain_dir.' '.$source_dir), $tmp_output, $retval);
+							}
+						}
+						
 						if($retval == 0){
-							chown($mail_backup_dir.'/'.$mail_backup_file, 'root');
-							chgrp($mail_backup_dir.'/'.$mail_backup_file, 'root');
+							chown($mail_backup_dir.'/'.$mail_backup_file, $backupusername);
+							chgrp($mail_backup_dir.'/'.$mail_backup_file, $backupgroup);
 							chmod($mail_backup_dir.'/'.$mail_backup_file, 0640);
 							/* Insert mail backup record in database */
-							$sql = "INSERT INTO mail_backup (server_id,parent_domain_id,mailuser_id,backup_mode,tstamp,filename,filesize) VALUES (".$conf['server_id'].",".$domain_rec['domain_id'].",".$rec['mailuser_id'].",'".$backup_mode."',".time().",'".$app->db->quote($mail_backup_file)."','".$app->functions->formatBytes(filesize($mail_backup_dir.'/'.$mail_backup_file))."')";
-							$app->db->query($sql);	
-							if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
+							$filesize = filesize($mail_backup_dir.'/'.$mail_backup_file);
+							$sql = "INSERT INTO mail_backup (server_id, parent_domain_id, mailuser_id, backup_mode, tstamp, filename, filesize) VALUES (?, ?, ?, ?, ?, ?, ?)";
+							$app->db->query($sql, $conf['server_id'], $domain_rec['domain_id'], $rec['mailuser_id'], $backup_mode, time(), $mail_backup_file, $filesize);	
+							if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $domain_rec['domain_id'], $rec['mailuser_id'], $backup_mode, time(), $mail_backup_file, $filesize);
+							unset($filesize);
 						} else {
 							/* Backup failed - remove archive */
 							if(is_file($mail_backup_dir.'/'.$mail_backup_file)) unlink($mail_backup_dir.'/'.$mail_backup_file);
+							// And remove backup-mdbox
+							if ($rec['maildir_format'] == 'mdbox') {
+								if(file_exists($rec['maildir'].'/backup'))  exec("su -c 'rm -rf ".$rec['maildir']."/backup'");
+							}
 							$app->log($mail_backup_file.' NOK:'.implode('',$tmp_output), LOGLEVEL_DEBUG);
 						}
 						/* Remove old backups */
@@ -134,30 +185,55 @@
 						for ($n = $backup_copies; $n <= 10; $n++) {
 							if(isset($files[$n]) && is_file($mail_backup_dir.'/'.$files[$n])) {
 								unlink($mail_backup_dir.'/'.$files[$n]);
-								$sql = "DELETE FROM mail_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = ".$domain_rec['domain_id']." AND filename = '".$app->db->quote($files[$n])."'";
-								$app->db->query($sql);
-								if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
+								$sql = "DELETE FROM mail_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
+								$app->db->query($sql, $conf['server_id'], $domain_rec['domain_id'], $files[$n]);
+								if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $domain_rec['domain_id'], $files[$n]);
 							}
 						}
 						unset($files);
 						unset($dir_handle);
 					}
 					/* Remove inactive backups */
-					if($rec['backup_interval'] == 'none') {
-						/* remove backups from db */
-						$sql = "DELETE FROM mail_backup WHERE server_id = ".$conf['server_id']." AND parent_domain_id = ".$domain_rec['domain_id']." AND mailuser_id = ".$rec['mailuser_id'];
-						$app->db->query($sql);
-						if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
+					if($rec['backup_interval'] == 'none' || $rec['backup_interval'] == '') {
+
 						/* remove archives */
-						$mail_backup_dir = $backup_dir.'/mail'.$rec['domain_id'];	
-						$mail_backup_file = 'mail'.$rec['mailuser_id'].'_*';
+						$mail_backup_dir = realpath($backup_dir.'/mail'.$domain_rec['domain_id']);
+						$mail_backup_file = 'mail'.$rec['mailuser_id'].'_';
 						if(is_dir($mail_backup_dir)) {
-							foreach (glob($mail_backup_dir.'/'.$mail_backup_file) as $filename) {
-								unlink($filename);
+							$dir_handle = opendir($mail_backup_dir.'/');
+							while ($file = readdir($dir_handle)) {
+								if(!is_dir($file)) {
+									if(substr($file,0,strlen($mail_backup_file)) == $mail_backup_file) {
+										unlink ($mail_backup_dir.'/'.$file);
+									}
+								}
 							}
+							if(count(glob($mail_backup_dir."/*", GLOB_NOSORT)) === 0) {
+								rmdir($mail_backup_dir);
+							}
+						}
+						/* remove backups from db */
+						$sql = "DELETE FROM mail_backup WHERE server_id = ? AND parent_domain_id = ? AND mailuser_id = ?";
+						$app->db->query($sql, $conf['server_id'], $domain_rec['domain_id'], $rec['mailuser_id']);
+						if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql, $conf['server_id'], $domain_rec['domain_id'], $rec['mailuser_id']);
+
+					}
+				}
+
+				// remove non-existing backups from database
+				$backups = $app->db->queryAllRecords("SELECT * FROM mail_backup WHERE server_id = ?", $conf['server_id']);
+				if(is_array($backups) && !empty($backups)){
+					foreach($backups as $backup){
+						$mail_backup_dir = $backup_dir.'/mail'.$backup['parent_domain_id'];
+						if(!is_file($mail_backup_dir.'/'.$backup['filename'])){
+							$sql = "DELETE FROM mail_backup WHERE server_id = ? AND parent_domain_id = ? AND filename = ?";
+							$app->db->query($sql, $conf['server_id'], $backup['parent_domain_id'], $backup['filename']);
+							if($app->db->dbHost != $app->dbmaster->dbHost) $app->dbmaster->query($sql);
 						}
 					}
 				}
+				if( $server_config['backup_dir_is_mount'] == 'y' ) $app->system->umount_backup_dir($backup_dir);
+				//* end run_backups
 			}
 		}
 

--
Gitblit v1.9.1