From 9ea57c38f77619af26d580f2355ec9d86c7e0f24 Mon Sep 17 00:00:00 2001 From: Dominik Müller <info@profi-webdesign.net> Date: Mon, 20 Jan 2014 12:24:04 -0500 Subject: [PATCH] Use -1 as "unsetted" value do not change parameter order in old functions --- server/plugins-available/iptables_plugin.inc.php | 68 +++++++++++++++++---------------- 1 files changed, 35 insertions(+), 33 deletions(-) diff --git a/server/plugins-available/iptables_plugin.inc.php b/server/plugins-available/iptables_plugin.inc.php index 247eb7b..92083bb 100644 --- a/server/plugins-available/iptables_plugin.inc.php +++ b/server/plugins-available/iptables_plugin.inc.php @@ -2,43 +2,43 @@ class iptables_plugin { - var $plugin_name = 'iptables_plugin'; - var $class_name = 'iptables_plugin'; + var $plugin_name = 'iptables_plugin'; + var $class_name = 'iptables_plugin'; - function onInstall() - { - global $conf; - /* + function onInstall() + { + global $conf; + /* if($conf['iptables']['installed'] = true) return true; else return false; */ - return false; - } + return false; + } - function onLoad() - { - global $app; - $app->plugins->registerEvent('iptables_insert',$this->plugin_name,'insert'); - $app->plugins->registerEvent('iptables_update',$this->plugin_name,'update'); - $app->plugins->registerEvent('iptables_delete',$this->plugin_name,'delete'); - } + function onLoad() + { + global $app; + $app->plugins->registerEvent('iptables_insert', $this->plugin_name, 'insert'); + $app->plugins->registerEvent('iptables_update', $this->plugin_name, 'update'); + $app->plugins->registerEvent('iptables_delete', $this->plugin_name, 'delete'); + } - function insert($event_name,$data) - { - global $app, $conf; - $this->update($event_name,$data); - } + function insert($event_name, $data) + { + global $app, $conf; + $this->update($event_name, $data); + } - function update($event_name,$data) - { - global $app, $conf; -/* + function update($event_name, $data) + { + global $app, $conf; + /* ok, here is where we do some fun stuff. First off we need to see the currently running iptables (sans the fail2ban) and compare with the database. This is the method that is good for multi servers and keeping the firewall read only so a comromised box will not corrupt the master server. -If the running iptables and the new iptables don't match, lets send a note to +If the running iptables and the new iptables don't match, lets send a note to the monitoring data to say that there is a difference. Maybe we can have the iptables gui inteface check the data field for changes and post a warning and or the changes as disabled rules. If an admin adds a rule on the comand line @@ -70,12 +70,14 @@ $data['new'] should have lots of fun stuff exec('iptables -I XYZ'); */ - } - - function delete($event_name,$data) - { - global $app, $conf; - exec('iptables -D xyz'); - } + } + + function delete($event_name, $data) + { + global $app, $conf; + exec('iptables -D xyz'); + } + } -?> \ No newline at end of file + +?> -- Gitblit v1.9.1