From b6912ffe12ad874a147ea75d84c20352f79e5a94 Mon Sep 17 00:00:00 2001 From: tbrehm <t.brehm@ispconfig.org> Date: Thu, 16 Sep 2010 07:48:17 -0400 Subject: [PATCH] Fixed: FS#1298 - mailfilter saving file in DOS format causing script to error --- server/plugins-available/mysql_clientdb_plugin.inc.php | 18 ++++++++++++++---- 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/server/plugins-available/mysql_clientdb_plugin.inc.php b/server/plugins-available/mysql_clientdb_plugin.inc.php index a1bb4fa..5d52e72 100644 --- a/server/plugins-available/mysql_clientdb_plugin.inc.php +++ b/server/plugins-available/mysql_clientdb_plugin.inc.php @@ -123,6 +123,11 @@ $app->log('Unable to open'.ISPC_LIB_PATH.'/mysql_clientdb.conf',LOGLEVEL_ERROR); return; } + + if($data["new"]["database_user"] == 'root') { + $app->log('User root not allowed for Client databases',LOGLEVEL_WARNING); + return; + } //* Connect to the database $link = mysql_connect($clientdb_host, $clientdb_user, $clientdb_password); @@ -142,7 +147,7 @@ if (mysql_query('CREATE DATABASE '.mysql_real_escape_string($data["new"]["database_name"]).$query_charset_table,$link)) { $app->log('Created MySQL database: '.$data["new"]["database_name"],LOGLEVEL_DEBUG); } else { - $app->log('Unable to connect to the database'.mysql_error($link),LOGLEVEL_ERROR); + $app->log('Unable to create the database'.mysql_error($link),LOGLEVEL_WARNING); } // Create the database user if database is active @@ -169,6 +174,11 @@ if($data["new"]["type"] == 'mysql') { if(!include(ISPC_LIB_PATH.'/mysql_clientdb.conf')) { $app->log('Unable to open'.ISPC_LIB_PATH.'/mysql_clientdb.conf',LOGLEVEL_ERROR); + return; + } + + if($data["new"]["database_user"] == 'root') { + $app->log('User root not allowed for Client databases',LOGLEVEL_WARNING); return; } @@ -274,20 +284,20 @@ if($this->process_host_list("DROP", "", $data["old"]["database_user"], "", $data["old"]["remote_ips"], $link)) { $app->log('Dropping mysql user: '.$data["old"]["database_user"],LOGLEVEL_DEBUG); } else { - $app->log('Error while dropping mysql user: '.$data["old"]["database_user"].' '.mysql_error($link),LOGLEVEL_ERROR); + $app->log('Error while dropping mysql user: '.$data["old"]["database_user"].' '.mysql_error($link),LOGLEVEL_WARNING); } } $db_host = 'localhost'; if(mysql_query("DROP USER '".mysql_real_escape_string($data["old"]["database_user"],$link)."'@'$db_host';",$link)) { $app->log('Dropping mysql user: '.$data["old"]["database_user"],LOGLEVEL_DEBUG); } else { - $app->log('Error while dropping mysql user: '.$data["old"]["database_user"].' '.mysql_error($link),LOGLEVEL_ERROR); + $app->log('Error while dropping mysql user: '.$data["old"]["database_user"].' '.mysql_error($link),LOGLEVEL_WARNING); } if(mysql_query('DROP DATABASE '.mysql_real_escape_string($data["old"]["database_name"],$link),$link)) { $app->log('Dropping mysql database: '.$data["old"]["database_name"],LOGLEVEL_DEBUG); } else { - $app->log('Error while dropping mysql database: '.$data["old"]["database_name"].' '.mysql_error($link),LOGLEVEL_ERROR); + $app->log('Error while dropping mysql database: '.$data["old"]["database_name"].' '.mysql_error($link),LOGLEVEL_WARNING); } mysql_query("FLUSH PRIVILEGES;",$link); -- Gitblit v1.9.1