From bbb85a4e2d6e557c14735ffef748a7c5e9033cef Mon Sep 17 00:00:00 2001
From: Marius Cramer <m.cramer@pixcept.de>
Date: Tue, 13 Jan 2015 11:13:14 -0500
Subject: [PATCH] - fixed js reference

---
 server/plugins-available/mail_plugin_dkim.inc.php |   18 ++++++++++++++----
 1 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/server/plugins-available/mail_plugin_dkim.inc.php b/server/plugins-available/mail_plugin_dkim.inc.php
index 3a451d3..9fb927e 100755
--- a/server/plugins-available/mail_plugin_dkim.inc.php
+++ b/server/plugins-available/mail_plugin_dkim.inc.php
@@ -117,14 +117,14 @@
 			$app->log('Amavis-config not found or not writeable.', LOGLEVEL_ERROR);
 			$check=false;
 		}
+
 		/* dir for dkim-keys writeable? */
 		$mail_config = $app->getconf->get_server_config($conf['server_id'], 'mail');
 		if (	isset($mail_config['dkim_path']) && 
 				!empty($mail_config['dkim_path']) && 
 				isset($data['new']['dkim_private']) && 
 				!empty($data['new']['dkim_private']) &&
-				$mail_config['dkim_path'] != '/' &&
-				$app->system->checkpath($mail_config['dkim_path'])
+				$mail_config['dkim_path'] != '/' 
 		) {
             if (!is_dir($mail_config['dkim_path'])) {
                 $app->log('DKIM Path '.$mail_config['dkim_path'].' not found - (re)created.', LOGLEVEL_DEBUG);
@@ -143,11 +143,21 @@
 					mkdir($mail_config['dkim_path'], 0755, true);
 					$app->log('No user amavis or vscan found - using root for '.$mail_config['dkim_path'], LOGLEVEL_WARNING);
 				}
-            }
+            } else {
+				if (!$app->system->checkpath($mail_config['dkim_path'])) {
+					$app->log('Unable to write DKIM settings - invalid DKIM-Path (symlink?)', LOGLEVEL_ERROR);
+					$check=false;
+				}
+			}
 
 			if (!is_writeable($mail_config['dkim_path'])) {
 				$app->log('DKIM Path '.$mail_config['dkim_path'].' not writeable.', LOGLEVEL_ERROR);
 				$check=false;
+			}
+
+			if ( !$app->system->checkpath($mail_config['dkim_path']) ) {
+				$app->log('DKIM Path '.$mail_config['dkim_path'].' failed in checkpath.', LOGLEVEL_ERROR);
+				$check = false;
 			}
 
 		} else {
@@ -184,7 +194,7 @@
 	 * @param string $key_file full path to the key-file
 	 * @param string $key_value private-key
 	 * @param string $key_domain mail-domain
-	 * @return bool - true when the key is written to disk
+	 * @return bool - true when the private key was written to disk
 	 */
 	function write_dkim_key($key_file, $key_value, $key_domain) {
 		global $app, $mailconfig;

--
Gitblit v1.9.1