From e5f4d29bd7b15c9428245bebc28c69da8c788b8d Mon Sep 17 00:00:00 2001 From: tbrehm <t.brehm@ispconfig.org> Date: Mon, 20 Aug 2007 11:22:31 -0400 Subject: [PATCH] Added a deprecated warning in the interface/sql/ directory. The database sql dump in this directory is not the current development release and the directory will be removed as the installation related code is now located in the install/ tree. The current sql file is available in install/sql/ --- interface/lib/classes/tform_actions.inc.php | 94 +++++++++++++++++++++++++++------------------- 1 files changed, 55 insertions(+), 39 deletions(-) diff --git a/interface/lib/classes/tform_actions.inc.php b/interface/lib/classes/tform_actions.inc.php index da4ad76..0ef8ec0 100644 --- a/interface/lib/classes/tform_actions.inc.php +++ b/interface/lib/classes/tform_actions.inc.php @@ -55,15 +55,15 @@ $app->tform->loadFormDef($tform_def_file); // Importing ID - $this->id = intval($_REQUEST["id"]); + $this->id = (isset($_REQUEST["id"]))?intval($_REQUEST["id"]):0; // show print version of the form - if($_GET["print_form"] == 1) { + if(isset($_GET["print_form"]) && $_GET["print_form"] == 1) { $this->onPrintForm(); } // send this form by email - if($_GET["send_form_by_mail"] == 1) { + if(isset($_GET["send_form_by_mail"]) && $_GET["send_form_by_mail"] == 1) { $this->onMailSendForm(); } @@ -102,9 +102,13 @@ $ext_where = ''; $sql = $app->tform->getSQL($this->dataRecord,$app->tform->getCurrentTab(),'UPDATE',$this->id,$ext_where); if($app->tform->errorMessage == '') { + + if($app->tform->formDef['db_history'] == 'yes') { + $old_data_record = $app->tform->getDataRecord($this->id); + } if(!empty($sql)) { - $app->db->query($sql); + $app->db->query($sql); if($app->db->errorMessage != '') die($app->db->errorMessage); } @@ -118,6 +122,14 @@ } $this->onAfterUpdate(); + + // Write data history (sys_datalog) + if($app->tform->formDef['db_history'] == 'yes') { + $new_data_record = $app->tform->getDataRecord($this->id); + $app->tform->datalogSave('UPDATE',$this->id,$old_data_record,$new_data_record); + unset($new_data_record); + unset($old_data_record); + } if($_REQUEST["next_tab"] == '') { $list_name = $_SESSION["s"]["form"]["return_to"]; @@ -129,19 +141,19 @@ $_SESSION["s"]["form"]["return_to"] = ''; session_write_close(); header($redirect); - // When a returnto variable is set - } elseif ($_SESSION["s"]["form"]["return_to_url"] != '') { - $redirect = $_SESSION["s"]["form"]["return_to_url"]; - $_SESSION["s"]["form"]["return_to_url"] = ''; - session_write_close(); - header("Location: ".$redirect); - exit; - // Use the default list of the form - } else { - header("Location: ".$app->tform->formDef['list_default']); - } - exit; - } else { + // When a returnto variable is set + } elseif ($_SESSION["s"]["form"]["return_to_url"] != '') { + $redirect = $_SESSION["s"]["form"]["return_to_url"]; + $_SESSION["s"]["form"]["return_to_url"] = ''; + session_write_close(); + header("Location: ".$redirect); + exit; + // Use the default list of the form + } else { + header("Location: ".$app->tform->formDef['list_default']); + } + exit; + } else { $this->onShow(); } } else { @@ -175,6 +187,13 @@ } $this->onAfterInsert(); + + // Write data history (sys_datalog) + if($app->tform->formDef['db_history'] == 'yes') { + $new_data_record = $app->tform->getDataRecord($this->id); + $app->tform->datalogSave('INSERT',$this->id,array(),$new_data_record); + unset($new_data_record); + } if($_REQUEST["next_tab"] == '') { @@ -253,30 +272,21 @@ if($this->id > 0) { // checking permissions - if($app->tform->formDef['auth'] == 'yes') { + if($app->tform->formDef['auth'] == 'yes' && $_SESSION["s"]["user"]["typ"] != 'admin') { if($app->tform->checkPerm($this->id,'d') == false) $app->error($app->lng('error_no_delete_permission')); } - $record_old = $app->db->queryOneRecord("SELECT * FROM ".$liste["table"]." WHERE ".$liste["table_idx"]." = ".$this->id); + //$this->dataRecord = $app->db->queryOneRecord("SELECT * FROM ".$liste["table"]." WHERE ".$liste["table_idx"]." = ".$this->id); + $this->dataRecord = $app->tform->getDataRecord($this->id); // Saving record to datalog when db_history enabled - if($form["db_history"] == 'yes') { - $diffrec = array(); - - foreach($record_old as $key => $val) { - // Record has changed - $diffrec[$key] = array('old' => $val, - 'new' => ''); - } - - $diffstr = $app->db->quote(serialize($diffrec)); - $username = $app->db->quote($_SESSION["s"]["user"]["username"]); - $dbidx = $app->tform->formDef['db_table_idx'].":".$this->id; - $sql = "INSERT INTO sys_datalog (dbtable,dbidx,action,tstamp,user,data) VALUES ('".$app->tform->formDef['db_table']."','$dbidx','d','".time()."','$username','$diffstr')"; - $app->db->query($sql); + if($app->tform->formDef["db_history"] == 'yes') { + //$old_data_record = $app->tform->getDataRecord($this->id); + $app->tform->datalogSave('DELETE',$this->id,$this->dataRecord,array()); } - $app->db->query("DELETE FROM ".$liste["table"]." WHERE ".$liste["table_idx"]." = ".$this->id); + $app->db->query("DELETE FROM ".$app->tform->formDef['db_table']." WHERE ".$app->tform->formDef['db_table_idx']." = ".$this->id." LIMIT 1"); + // loading plugins $next_tab = $app->tform->getCurrentTab(); @@ -287,6 +297,8 @@ foreach($this->plugins as $plugin) { $plugin->onDelete(); } + + $this->onAfterDelete(); } //header("Location: ".$liste["file"]."?PHPSESSID=".$_SESSION["s"]["id"]); @@ -301,6 +313,10 @@ } exit; + } + + function onAfterDelete() { + global $app, $conf; } /** @@ -433,7 +449,7 @@ $app->tpl_defaults(); // Show the navigation bar of the form - if($app->tform->formDef['navibar'] == 'yes') { + if(isset($app->tform->formDef['navibar']) && $app->tform->formDef['navibar'] == 'yes') { $navibar = ''; if($app->tform->formDef['template_print'] != '') { $navibar .= '<a href="'.$app->tform->formDef['action'].'?id='.$this->id.'&print_form=1" target="_blank"><img src="../themes/iprg/icons/printer.png" border="0" alt="Drucken" /></a> '; @@ -485,10 +501,10 @@ // bestehenden Datensatz anzeigen if($app->tform->errorMessage == '') { - if($app->tform->formDef['auth'] == 'no') { - $sql = "SELECT * FROM ".$app->tform->formDef['db_table']." WHERE ".$app->tform->formDef['db_table_idx']." = ".$this->id; + if($app->tform->formDef['auth'] == 'yes' && $_SESSION["s"]["user"]["typ"] != 'admin') { + $sql = "SELECT * FROM ".$app->tform->formDef['db_table']." WHERE ".$app->tform->formDef['db_table_idx']." = ".$this->id." AND ".$app->tform->getAuthSQL('u'); } else { - $sql = "SELECT * FROM ".$app->tform->formDef['db_table']." WHERE ".$app->tform->formDef['db_table_idx']." = ".$this->id." AND ".$app->tform->getAuthSQL('u'); + $sql = "SELECT * FROM ".$app->tform->formDef['db_table']." WHERE ".$app->tform->formDef['db_table_idx']." = ".$this->id; } if(!$record = $app->db->queryOneRecord($sql)) $app->error($app->lng('error_no_view_permission')); } else { @@ -514,7 +530,7 @@ function loadPlugins($next_tab) { global $app; - if(is_array($app->tform->formDef["tabs"][$next_tab]["plugins"])) { + if(@is_array($app->tform->formDef["tabs"][$next_tab]["plugins"])) { $app->load('plugin_base'); foreach($app->tform->formDef["tabs"][$next_tab]["plugins"] as $plugin_name => $plugin_settings) { $plugin_class = $plugin_settings["class"]; -- Gitblit v1.9.1