From e94a9fb5e4b6a2bc07e0bb4cf8ea35fc70c4bbf0 Mon Sep 17 00:00:00 2001
From: tbrehm <t.brehm@ispconfig.org>
Date: Thu, 10 May 2012 12:31:27 -0400
Subject: [PATCH] Merged revisions 3049-3051,3053-3054,3058,3070,3074-3077,3082,3086-3088,3091-3092,3094-3095 from stable branch.

---
 server/plugins-available/firewall_plugin.inc.php |   26 +++++++++++++++-----------
 1 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/server/plugins-available/firewall_plugin.inc.php b/server/plugins-available/firewall_plugin.inc.php
index 9039946..6697798 100644
--- a/server/plugins-available/firewall_plugin.inc.php
+++ b/server/plugins-available/firewall_plugin.inc.php
@@ -38,7 +38,11 @@
 	function onInstall() {
 		global $conf;
 		
-		return true;
+		if($conf['bastille']['installed'] = true && $conf['services']['firewall'] == true) {
+			return true;
+		} else {
+			return false;
+		}
 		
 	}
 	
@@ -76,7 +80,7 @@
 		$tcp_ports = '';
 		$udp_ports = '';
 		
-		$ports = explode(',',$data["new"]["tcp_port"]);
+		$ports = explode(',',$data['new']['tcp_port']);
 		if(is_array($ports)) {
 			foreach($ports as $p) {
 				if(strstr($p,':')) {
@@ -90,7 +94,7 @@
 		}
 		$tcp_ports = trim($tcp_ports);
 		
-		$ports = explode(',',$data["new"]["udp_port"]);
+		$ports = explode(',',$data['new']['udp_port']);
 		if(is_array($ports)) {
 			foreach($ports as $p) {
 				if(strstr($p,':')) {
@@ -106,21 +110,21 @@
 		
 		$app->load('tpl');
 		$tpl = new tpl();
-		$tpl->newTemplate("bastille-firewall.cfg.master");
+		$tpl->newTemplate('bastille-firewall.cfg.master');
 		
-		$tpl->setVar("TCP_PUBLIC_SERVICES",$tcp_ports);
-		$tpl->setVar("UDP_PUBLIC_SERVICES",$udp_ports);
+		$tpl->setVar('TCP_PUBLIC_SERVICES',$tcp_ports);
+		$tpl->setVar('UDP_PUBLIC_SERVICES',$udp_ports);
 		
 		file_put_contents('/etc/Bastille/bastille-firewall.cfg',$tpl->grab());
 		$app->log('Writing firewall configuration /etc/Bastille/bastille-firewall.cfg',LOGLEVEL_DEBUG);
 		unset($tpl);
 		
-		if($data["new"]["active"] == 'y') {
-			exec('/etc/init.d/bastille-firewall restart');
+		if($data['new']['active'] == 'y') {
+			exec($conf['init_scripts'] . '/' . 'bastille-firewall restart');
 			if(@is_file('/etc/debian_version')) exec('update-rc.d bastille-firewall defaults');
 			$app->log('Restarting the firewall',LOGLEVEL_DEBUG);
 		} else {
-			exec('/etc/init.d/bastille-firewall stop');
+			exec($conf['init_scripts'] . '/' . 'bastille-firewall stop');
 			if(@is_file('/etc/debian_version')) exec('update-rc.d -f bastille-firewall remove');
 			$app->log('Stopping the firewall',LOGLEVEL_DEBUG);
 		}
@@ -131,7 +135,7 @@
 	function delete($event_name,$data) {
 		global $app, $conf;
 		
-		exec('/etc/init.d/bastille-firewall stop');
+		exec($conf['init_scripts'] . '/' . 'bastille-firewall stop');
 		if(@is_file('/etc/debian_version')) exec('update-rc.d -f bastille-firewall remove');
 		$app->log('Stopping the firewall',LOGLEVEL_DEBUG);
 		
@@ -142,4 +146,4 @@
 
 } // end class
 
-?>
\ No newline at end of file
+?>

--
Gitblit v1.9.1