From e94a9fb5e4b6a2bc07e0bb4cf8ea35fc70c4bbf0 Mon Sep 17 00:00:00 2001 From: tbrehm <t.brehm@ispconfig.org> Date: Thu, 10 May 2012 12:31:27 -0400 Subject: [PATCH] Merged revisions 3049-3051,3053-3054,3058,3070,3074-3077,3082,3086-3088,3091-3092,3094-3095 from stable branch. --- server/plugins-available/mailman_plugin.inc.php | 23 +++++++++++++---------- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/server/plugins-available/mailman_plugin.inc.php b/server/plugins-available/mailman_plugin.inc.php index 823bf85..5a4593a 100644 --- a/server/plugins-available/mailman_plugin.inc.php +++ b/server/plugins-available/mailman_plugin.inc.php @@ -73,11 +73,11 @@ $this->update_config(); - exec("/usr/lib/mailman/bin/newlist -u ".$data["new"]["domain"]." -e ".$data["new"]["domain"]." ".$data["new"]["listname"]." ".$data["new"]["email"]." ".$data["new"]["password"].""); + exec("/usr/lib/mailman/bin/newlist -u ".escapeshellcmd($data["new"]["domain"])." -e ".escapeshellcmd($data["new"]["domain"])." ".escapeshellcmd($data["new"]["listname"])." ".escapeshellcmd($data["new"]["email"])." ".escapeshellcmd($data["new"]["password"]).""); exec($conf['init_scripts'] . '/' . 'mailman reload &> /dev/null'); - $app->db->query("UPDATE mail_mailinglist SET password = '' WHERE mailinglist_id = ".$data["new"]['mailinglist_id']); + $app->db->query("UPDATE mail_mailinglist SET password = '' WHERE mailinglist_id = ".$app->db->quote($data["new"]['mailinglist_id'])); } @@ -85,12 +85,11 @@ function update($event_name,$data) { global $app, $conf; - exec("/usr/lib/mailman/bin/change_pw -l ".$data["new"]["listname"]." -p ".$data["new"]["password"].""); - - exec($conf['init_scripts'] . '/' . 'mailman reload &> /dev/null'); - - $app->db->query("UPDATE mail_mailinglist SET password = '' WHERE mailinglist_id = ".$data["new"]['mailinglist_id']); - + if($data["new"]["password"] != $data["old"]["password"] && $data["new"]["password"] != '') { + exec("/usr/lib/mailman/bin/change_pw -l ".escapeshellcmd($data["new"]["listname"])." -p ".escapeshellcmd($data["new"]["password"]).""); + exec($conf['init_scripts'] . '/' . 'mailman reload &> /dev/null'); + $app->db->query("UPDATE mail_mailinglist SET password = '' WHERE mailinglist_id = ".$app->db->quote($data["new"]['mailinglist_id'])); + } } function delete($event_name,$data) { @@ -98,7 +97,7 @@ $this->update_config(); - exec("/usr/lib/mailman/bin/rmlist -a ".$data["old"]["listname"]); + exec("/usr/lib/mailman/bin/rmlist -a ".escapeshellcmd($data["old"]["listname"])); exec($conf['init_scripts'] . '/' . 'mailman reload &> /dev/null'); @@ -114,7 +113,11 @@ $server_config = $app->getconf->get_server_config($conf['server_id'], 'server'); // load files - $content = file_get_contents($conf["rootpath"]."/conf/mm_cfg.py.master"); + if(file_exists($conf["rootpath"]."/conf-custom/mm_cfg.py.master")) { + $content = file_get_contents($conf["rootpath"]."/conf-custom/mm_cfg.py.master"); + } else { + $content = file_get_contents($conf["rootpath"]."/conf/mm_cfg.py.master"); + } $old_file = file_get_contents($this->mailman_config_dir."/mm_cfg.py"); $old_options = array(); -- Gitblit v1.9.1