From e9d71f1635dd83b00b1667dbbbdbce8da0058bc7 Mon Sep 17 00:00:00 2001 From: tbrehm <t.brehm@ispconfig.org> Date: Tue, 04 Jan 2011 08:43:42 -0500 Subject: [PATCH] Fixed: FS#1455 - disable vhost on secondary ISPConfig server does not work --- server/plugins-available/shelluser_jailkit_plugin.inc.php | 64 ++++++++++++++++++++++++++----- 1 files changed, 53 insertions(+), 11 deletions(-) diff --git a/server/plugins-available/shelluser_jailkit_plugin.inc.php b/server/plugins-available/shelluser_jailkit_plugin.inc.php index 308178f..b1ee45e 100755 --- a/server/plugins-available/shelluser_jailkit_plugin.inc.php +++ b/server/plugins-available/shelluser_jailkit_plugin.inc.php @@ -84,13 +84,17 @@ $this->data = $data; $this->app = $app; $this->jailkit_config = $app->getconf->get_server_config($conf["server_id"], 'jailkit'); + + $this->_update_website_security_level(); $this->_setup_jailkit_chroot(); - $command .= 'usermod --unlock '.escapeshellcmd($data['new']['username']); + $this->_add_jailkit_user(); + + $command .= 'usermod -U '.escapeshellcmd($data['new']['username']); exec($command); - $this->_add_jailkit_user(); + $this->_update_website_security_level(); } $app->log("Jailkit Plugin -> insert username:".$data['new']['username'],LOGLEVEL_DEBUG); @@ -119,9 +123,13 @@ $this->data = $data; $this->app = $app; $this->jailkit_config = $app->getconf->get_server_config($conf["server_id"], 'jailkit'); + + $this->_update_website_security_level(); $this->_setup_jailkit_chroot(); $this->_add_jailkit_user(); + + $this->_update_website_security_level(); } $app->log("Jailkit Plugin -> update username:".$data['new']['username'],LOGLEVEL_DEBUG); @@ -151,8 +159,13 @@ //commented out proved to be dangerous on config errors //exec('rm -rf '.$data['old']['dir'].$jailkit_chroot_userhome); + if(@is_dir($data['old']['dir'].$jailkit_chroot_userhome)) { + $command = 'userdel'; + $command .= ' '.escapeshellcmd($data['old']['username']); + exec($command); + $app->log("Jailkit Plugin -> delete chroot home:".$data['old']['dir'].$jailkit_chroot_userhome,LOGLEVEL_DEBUG); + } - $app->log("Jailkit Plugin -> delete chroot home:".$data['old']['dir'].$jailkit_chroot_userhome,LOGLEVEL_DEBUG); } $app->log("Jailkit Plugin -> delete username:".$data['old']['username'],LOGLEVEL_DEBUG); @@ -188,7 +201,7 @@ $tpl->setVar('home_dir',$this->_get_home_dir("")); $bashrc = escapeshellcmd($this->data['new']['dir']).'/etc/bash.bashrc'; - if(@is_file($bashrc)) exec('rm '.$bashrc); + if(@is_file($bashrc)) unlink($bashrc); file_put_contents($bashrc,$tpl->grab()); unset($tpl); @@ -201,7 +214,7 @@ $tpl->setVar('domain',$web['domain']); $motd = escapeshellcmd($this->data['new']['dir']).'/var/run/motd'; - if(@is_file($motd)) exec('rm '.$motd); + if(@is_file($motd)) unlink($motd); file_put_contents($motd,$tpl->grab()); @@ -221,7 +234,7 @@ function _get_home_dir($username) { - return str_replace("[username]",escapeshellcmd($username),$this->jailkit_config["jailkit_chroot_home"]); + return str_replace("[username]",escapeshellcmd($username),$this->jailkit_config['jailkit_chroot_home']); } function _add_jailkit_user() @@ -229,6 +242,9 @@ //add the user to the chroot $jailkit_chroot_userhome = $this->_get_home_dir($this->data['new']['username']); $jailkit_chroot_puserhome = $this->_get_home_dir($this->data['new']['puser']); + + if(!is_dir($this->data['new']['dir'].'/etc')) mkdir($this->data['new']['dir'].'/etc', 0755); + if(!is_file($this->data['new']['dir'].'/etc/passwd')) touch($this->data['new']['dir'].'/etc/passwd', 0755); // IMPORTANT! // ALWAYS create the user. Even if the user was created before @@ -245,19 +261,45 @@ $this->app->log("Added jailkit user to chroot with command: ".$command,LOGLEVEL_DEBUG); - exec("mkdir -p ".escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_userhome)); - exec("chown ".$this->data['new']['username'].":".$this->data['new']['pgroup']." ".escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_userhome)); + mkdir(escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_userhome), 0755, true); + chown(escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_userhome), $this->data['new']['username']); + chgrp(escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_userhome), $this->data['new']['pgroup']); $this->app->log("Added created jailkit user home in : ".$this->data['new']['dir'].$jailkit_chroot_userhome,LOGLEVEL_DEBUG); - exec("mkdir -p ".escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_puserhome)); - exec("chown ".$this->data['new']['puser'].":".$this->data['new']['pgroup']." ".escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_puserhome)); + mkdir(escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_puserhome), 0755, true); + chown(escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_puserhome), $this->data['new']['puser']); + chgrp(escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_puserhome), $this->data['new']['pgroup']); $this->app->log("Added created jailkit parent user home in : ".$this->data['new']['dir'].$jailkit_chroot_puserhome,LOGLEVEL_DEBUG); } + //* Update the website root directory permissions depending on the security level + function _update_website_security_level() { + global $app,$conf; + + // load the server configuration options + $app->uses("getconf"); + $web_config = $app->getconf->get_server_config($conf["server_id"], 'web'); + + // Get the parent website of this shell user + $web = $app->db->queryOneRecord("SELECT * FROM web_domain WHERE domain_id = ".$this->data['new']['parent_domain_id']); + + //* If the security level is set to high + if($web_config['security_level'] == 20) { + $this->_exec('chmod 755 '.escapeshellcmd($web["document_root"])); + $this->_exec('chown root:root '.escapeshellcmd($web["document_root"])); + } + + } + //* Wrapper for exec function for easier debugging + private function _exec($command) { + global $app; + $app->log('exec: '.$command,LOGLEVEL_DEBUG); + exec($command); + } } // end class -?> \ No newline at end of file +?> -- Gitblit v1.9.1